Skip to content

fix: handle dot notation on local variables in grind parameters #11573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kim-em merged 1 commit into from
Dec 11, 2025
Merged

fix: handle dot notation on local variables in grind parameters #11573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/Lean/Elab/Tactic/Grind/Param.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,17 @@ public def elabGrindParams (params : Grind.Params) (ps : TSyntaxArray ``Parser.T
else
params := { params with ematch := (← params.ematch.eraseDecl declName) }
| `(Parser.Tactic.grindParam| $[$mod?:grindMod]? $id:ident) =>
params ← processParam params p mod? id (minIndexable := false) (only := only) (incremental := incremental)
-- Check if this is dot notation on a local variable (e.g., `n.triv` for `Nat.triv n`).
-- If so, process as term to let elaboration resolve the dot notation properly.
if let some (_, _ :: _) := (← resolveLocalName id.getId) then
params ← processTermParam params p mod? id (minIndexable := false)
else
params ← processParam params p mod? id (minIndexable := false) (only := only) (incremental := incremental)
| `(Parser.Tactic.grindParam| ! $[$mod?:grindMod]? $id:ident) =>
params ← processParam params p mod? id (minIndexable := true) (only := only) (incremental := incremental)
if let some (_, _ :: _) := (← resolveLocalName id.getId) then
params ← processTermParam params p mod? id (minIndexable := true)
else
params ← processParam params p mod? id (minIndexable := true) (only := only) (incremental := incremental)
| `(Parser.Tactic.grindParam| $[$mod?:grindMod]? $e:term) =>
params ← processTermParam params p mod? e (minIndexable := false)
| `(Parser.Tactic.grindParam| ! $[$mod?:grindMod]? $e:term) =>
Expand Down
7 changes: 7 additions & 0 deletions tests/lean/run/grind_local_hyps.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,10 @@ example : 0 = 0 := by
example : 0 = 0 := by
have h : 1 = 1 := rfl
grind only [h]

-- Checks that dot notation on a local variable for a global theorem is accepted.
-- `n.triv` means `Nat.triv n`, not a local hypothesis.
theorem Nat.triv (n : Nat) : n = n := rfl

example (n : Nat) : n = n := by
grind [n.triv]
Loading