chore: partially revert "feat: lake: use lean --setup"
#8736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tydeu
changed the title
lean --setup "lean --setup"
Member
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 9874820. Benchmark Metric Change
=====================================================
+ bv_decide_mod task-clock -1.3% (-32.9 σ)
+ bv_decide_mod wall-clock -1.3% (-20.7 σ)
+ lake build clean instructions -28.9% (-881.0 σ)
+ lake build clean maxrss -47.8% (-86.2 σ)
+ lake build clean task-clock -28.0% (-123.4 σ)
+ lake build clean wall-clock -46.7% (-162.6 σ)
+ lake build no-op instructions -97.8% (-39187.8 σ)
+ lake build no-op maxrss -48.5% (-21.1 σ)
+ lake build no-op task-clock -99.3% (-18926.0 σ)
+ lake build no-op wall-clock -96.1% (-1543.4 σ)
+ nat_repr branches -1.2% (-165.9 σ)
+ stdlib grind dsimp -19.1% (-22.4 σ)
- workspaceSymbols task-clock 8.2% (48.8 σ)
- workspaceSymbols wall-clock 8.2% (48.2 σ) |
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 12, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 12, 2025
Collaborator
|
Mathlib CI status (docs):
|
leanprover-community-bot
added
the
builds-mathlib
This was referenced Jun 14, 2025
algebraic-dev
pushed a commit
to algebraic-dev/lean4
that referenced
this pull request
Jun 18, 2025
…8736) This PR partially reverts leanprover#8024 which introduced a significant Lake performance regression during builds. Once the cause is discovered and fixed, a similar PR will be made to revert this.
algebraic-dev
pushed a commit
to algebraic-dev/lean4
that referenced
this pull request
Jun 18, 2025
This PR reintroduces the basics of `lean --setup` integration into Lake without the module computation which is still undergoing performance debugging in leanprover#8787. Partially reverts leanprover#8736 and partially reimplements leanprover#8447.
wkrozowski
pushed a commit
to wkrozowski/lean4
that referenced
this pull request
Jun 24, 2025
…8736) This PR partially reverts leanprover#8024 which introduced a significant Lake performance regression during builds. Once the cause is discovered and fixed, a similar PR will be made to revert this.
wkrozowski
pushed a commit
to wkrozowski/lean4
that referenced
this pull request
Jun 24, 2025
This PR reintroduces the basics of `lean --setup` integration into Lake without the module computation which is still undergoing performance debugging in leanprover#8787. Partially reverts leanprover#8736 and partially reimplements leanprover#8447.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially reverts #8447 which introduced a significant Lake performance regression during builds. Once the cause is discovered and fixed, a similar PR will be made to revert this.