Conversation
rafal-lal
force-pushed
the
rlal-refactor-setup
branch
from
6d7ee00 to
7e09370
Compare
rafal-lal
force-pushed
the
rlal-cluster-api-refactor
branch
from
909751a to
884459f
Compare
rafal-lal
force-pushed
the
rlal-refactor-setup
branch
2 times, most recently
from
c9824b5 to
e56be69
Compare
Signed-off-by: Rafal Lal <rafal.lal@tietoevry.com>
- Replace HttpHelper module with simple download function in utils.cr. Also add specs for it. - Remove unused code (YAGNI principle) - Add setup/constant.cr file with versions and links to the tools Signed-off-by: Rafal Lal <rafal.lal@tietoevry.com>
rafal-lal
force-pushed
the
rlal-refactor-setup
branch
2 times, most recently
from
6316a75 to
95627e0
Compare
- Fill setup/constants with consts with versions, urls and so on - Fix build issues - Refactor few baseline setup tasks (setup, cluster_setup, cnf_setup) - Add SAM namespace called 'setup' to group setup tasks - Remove unused cnf_conformance_setup.cr file Signed-off-by: Rafal Lal <rafal.lal@tietoevry.com>
Signed-off-by: Rafal Lal <rafal.lal@tietoevry.com>
rafal-lal
force-pushed
the
rlal-refactor-setup
branch
from
fd32aff to
1b9c975
Compare
Signed-off-by: Rafal Lal <rafal.lal@tietoevry.com>
rafal-lal
force-pushed
the
rlal-refactor-setup
branch
from
1b9c975 to
94d3dbc
Compare
- Refactor logs with usage of .for(), make them more informative - Add error handling - Clean the code - Change logic of testcase to look if cluster on which CNF is running was provisioned by Cluster API and not if it has Cluster API manager installed - Update spec for it - Run autoformatter Signed-off-by: Rafal Lal <rafal.lal@tietoevry.com>
rafal-lal
force-pushed
the
rlal-cluster-api-refactor
branch
from
884459f to
acf2afc
Compare
rafal-lal
force-pushed
the
rlal-refactor-setup
branch
3 times, most recently
from
9e35500 to
c9c4c55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor 'cluster_api_setup' and redesign 'cluster_api_enabled' test. More info in comment in #1981.
TODO for myself: update docs
Issues:
Refs: #1981
How has this been tested:
Types of changes:
Checklist:
Documentation
Code Review
Issue