-
Notifications
You must be signed in to change notification settings - Fork 3
[feat] Add gene expression and cell types over time #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a2e5311
[fix] Move gene_col_name to outside the perturbations
ehuan2 554029d
[fix] Reorganized perturbation (generator pattern) for future
ehuan2 8034895
[fix] Fix graph viz with OT-CFM for setup later
ehuan2 1abacec
[feat] Add in plotting of cell types across time
ehuan2 dd3a717
[feat] Add in random baseline to the plot
ehuan2 784b7f1
[feat] Add in gene measurements over time
ehuan2 97be6f7
[fix] Redo perturbation hierarchy for ease of use
ehuan2 30174fd
[feat] Add in plotting of gene expression over time
ehuan2 9aba479
[feat] Add in max and min measures of gene expression
ehuan2 f0cdff0
[feat] Add in global perturbation to apply to data
ehuan2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,8 @@ outputs/ | |
| logs/ | ||
| data | ||
| data/ | ||
| grn_data | ||
| grn_data/ | ||
|
|
||
| # UV stuff | ||
| .python-version | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,3 +7,6 @@ method: | |
|
|
||
| metrics: | ||
| - name: MetaPerturbation | ||
| # - name: StackedBarPlot | ||
| # - name: StackedBarPlot | ||
| # from_tp_zero: True | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the reason for this step? we would need to do this in all methods to remain consistent - were the count distributions completely off without it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah so OT-CFM would explode the counts otherwise, so clipping it and then renormalizing it was the best way to get it done properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok do we reckon we do it for all methods or on a case-by-case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I can go through the others and see if it's a recurring issue - if so it's worth raising as a general problem or highlighting as just an OT-CFm thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouhh yeah good idea, actually I think something that would be good generally would be to move everything (generate_next_gex, etc.) to rely on a separate move_gex_t_t1 instead. Will raise this in an issue, and then we can force it to be an all methods thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which is done here: #127