Skip to content

fix: Add wrapped error type in stream.go #3237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sukunrt merged 4 commits into from
Mar 21, 2025
Merged

fix: Add wrapped error type in stream.go #3237

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7db099a
add wrapped error in stream.go
Prabhat1308 Mar 17, 2025
2994c15
change to use already defined StreamError
Prabhat1308 Mar 17, 2025
e4c9549
use remote from webtransport.StreamError
Prabhat1308 Mar 17, 2025
6945f3e
remove reduntant check and add err instead of streamErr
Prabhat1308 Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions p2p/transport/webtransport/stream.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,29 @@ var _ network.MuxedStream = &stream{}
func (s *stream) Read(b []byte) (n int, err error) {
n, err = s.Stream.Read(b)
if err != nil && errors.Is(err, &webtransport.StreamError{}) {
err = network.ErrReset
var streamErr *webtransport.StreamError
if errors.As(err, &streamErr) {
err = &network.StreamError{
ErrorCode: 0,
Remote: streamErr.Remote,
TransportError: streamErr,
Comment thread
Prabhat1308 marked this conversation as resolved.
Outdated
}
}
}
return n, err
}

func (s *stream) Write(b []byte) (n int, err error) {
n, err = s.Stream.Write(b)
if err != nil && errors.Is(err, &webtransport.StreamError{}) {
err = network.ErrReset
var streamErr *webtransport.StreamError
if errors.As(err, &streamErr) {
err = &network.StreamError{
ErrorCode: 0,
Remote: streamErr.Remote,
TransportError: streamErr,
}
}
Comment thread
Prabhat1308 marked this conversation as resolved.
}
return n, err
}
Expand Down