fix: use publicKey.x instead of privateKey.x #2926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although [RFC7518 6.3.2](https://datatracker.ietf.org/doc/html/rfc7518#section-6.3.2) specifies that private key JWKs must include all the fields present in the public key, this is not the case for the implementation of `node:crypto.generateKeyPairSync` in the deno runtime. While Node returns the (same) `x` property in both, the `privateKey` and the `publicKey`, Deno only returns the `x` property in `publicKey` (i.e. [no x here](https://github.com/denoland/deno/blob/88490d092751288f736855b2418a4da606a31ce7/ext/node/ops/crypto/keys.rs#L1475)). This change should not affect any Node users, but would enable the use of libp2p on Deno.
d70-t
changed the title
d70-t
changed the title
Member
|
That RFC link only refers to RSA keys, the code change here is for Ed25519 keys? Seems fine though, thanks for opening this PR. |
achingbrain
approved these changes
Feb 3, 2025
achingbrain
added a commit
that referenced
this pull request
Feb 3, 2025
Although [RFC7518 6.3.2](https://datatracker.ietf.org/doc/html/rfc7518#section-6.3.2) specifies that private key JWKs must include all the fields present in the public key, this is not the case for the implementation of `node:crypto.generateKeyPairSync` in the deno runtime. While Node returns the (same) `x` property in both, the `privateKey` and the `publicKey`, Deno only returns the `x` property in `publicKey` (i.e. [no x here](https://github.com/denoland/deno/blob/88490d092751288f736855b2418a4da606a31ce7/ext/node/ops/crypto/keys.rs#L1475)). This change should not affect any Node users, but would enable the use of libp2p on Deno. Co-authored-by: Alex Potsides <[email protected]>
Contributor
Author
|
Sorry, my bad. Elliptic curves are in section 6.2 right above. But it's the same story. |
Merged
Member
|
Very true. Is there an issue on the Deno repo about this? It should implement the |
Contributor
Author
|
I opened another issue at denoland/deno#27972 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: ed25519 generateKeyPairSync: use publicKey.x instead of privateKey.x
Description
Although RFC7518 6.3.2 specifies that private key JWKs must include all the fields present in the public key, this is not the case for the implementation of
node:crypto.generateKeyPairSyncin the deno runtime.While Node returns the (same)
xproperty in both, theprivateKeyand thepublicKey, Deno only returns thexproperty inpublicKey(i.e. no x here).This change should not affect any Node users, but would enable the use of libp2p on Deno.
Notes & open questions
Change checklist