Skip to content

fix: use publicKey.x instead of privateKey.x #2926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
achingbrain merged 2 commits into from
Feb 3, 2025
Merged

fix: use publicKey.x instead of privateKey.x #2926

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0fc170
ed25519 generateKeyPairSync: use publicKey.x instead of privateKey.x
d70-t Jan 27, 2025
8d65db3
Merge branch 'main' into patch-1
achingbrain Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/crypto/src/keys/ed25519/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export function generateKey (): Uint8ArrayKeyPair {
// @ts-expect-error node types are missing jwk as a format
const privateKeyRaw = uint8arrayFromString(key.privateKey.d, 'base64url')
// @ts-expect-error node types are missing jwk as a format
const publicKeyRaw = uint8arrayFromString(key.privateKey.x, 'base64url')
const publicKeyRaw = uint8arrayFromString(key.publicKey.x, 'base64url')

return {
privateKey: uint8arrayConcat([privateKeyRaw, publicKeyRaw], privateKeyRaw.byteLength + publicKeyRaw.byteLength),
Expand Down
Loading