Skip to content

Conversation

@joebowbeer
Copy link
Contributor

  • Give up com.noisepages.nettoyeur:midi

Reimplement Midi adapters using Android Midi API,
reusing Peter's (from/to)WireConverters coming from: https://github.com/nettoyeurny/btmidi/blob/master/AndroidMidi/src/com/noisepages/nettoyeur/midi/

  • Midi adapters: handle multiple devices, and javadoc-ument code

Ant1r and others added 6 commits July 3, 2025 23:11
* Give up com.noisepages.nettoyeur:midi

Reimplement Midi adapters using Android Midi API,
reusing Peter's (from/to)WireConverters coming from:
https://github.com/nettoyeurny/btmidi/blob/master/AndroidMidi/src/com/noisepages/nettoyeur/midi/

* Midi adapters: handle multiple devices, and javadoc-ument code
@joebowbeer joebowbeer requested a review from tkirshboim July 4, 2025 08:34
@joebowbeer joebowbeer marked this pull request as draft July 4, 2025 08:35
@joebowbeer
Copy link
Contributor Author

This is @Ant1r's reimplementation of MIDI along with some build fixes / upgrades that I added.

However, the minimum ndkVersion supported by the minimum Ubuntu runner is now erroring on usleep and clock_gettime:

We need to fix the build before we can merge.

@joebowbeer
Copy link
Contributor Author

@Ant1r @tkirshboim Can someone create a PR to update libpd with the "fixed" (hopefully) opensl_stream code?

@Ant1r
Copy link
Contributor

Ant1r commented Jul 6, 2025

I can take care of it. Maybe @danomatika can handle this quick update?

@danomatika
Copy link
Member

@Ant1r Actually, would you like to maintain this repo? I really have had nothing to do with it.

@Ant1r
Copy link
Contributor

Ant1r commented Jul 6, 2025

We were talking about libpd repo.

We would need to update the opensl module.

(actually I think this module should probably be used by pd-for-android instead; it would be better to have all android stuff moved from libpd to pd-for-android, but I think it's another story).

@joebowbeer
Copy link
Contributor Author

@danomatika As things are now, the opensl_stream code in libpd needs to be updated:

https://github.com/libpd/libpd/tree/master/jni

Then libpd in pd-for-android can be updated

@joebowbeer
Copy link
Contributor Author

obsolete

@joebowbeer joebowbeer closed this Nov 2, 2025
@joebowbeer joebowbeer deleted the joebowbeer-patch-2 branch November 2, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants