-
Notifications
You must be signed in to change notification settings - Fork 93
Give up com.noisepages.nettoyeur:midi and reimplement Midi (#129) #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Give up com.noisepages.nettoyeur:midi Reimplement Midi adapters using Android Midi API, reusing Peter's (from/to)WireConverters coming from: https://github.com/nettoyeurny/btmidi/blob/master/AndroidMidi/src/com/noisepages/nettoyeur/midi/ * Midi adapters: handle multiple devices, and javadoc-ument code
|
This is @Ant1r's reimplementation of MIDI along with some build fixes / upgrades that I added. However, the minimum
We need to fix the build before we can merge. |
|
@Ant1r @tkirshboim Can someone create a PR to update libpd with the "fixed" (hopefully) opensl_stream code? |
|
I can take care of it. Maybe @danomatika can handle this quick update? |
|
@Ant1r Actually, would you like to maintain this repo? I really have had nothing to do with it. |
|
We were talking about libpd repo. We would need to update the opensl module. (actually I think this module should probably be used by pd-for-android instead; it would be better to have all android stuff moved from libpd to pd-for-android, but I think it's another story). |
|
@danomatika As things are now, the opensl_stream code in libpd needs to be updated: https://github.com/libpd/libpd/tree/master/jni Then libpd in pd-for-android can be updated |
|
obsolete |
Reimplement Midi adapters using Android Midi API,
reusing Peter's (from/to)WireConverters coming from: https://github.com/nettoyeurny/btmidi/blob/master/AndroidMidi/src/com/noisepages/nettoyeur/midi/