fix samplerate handling #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joebowbeer
approved these changes
Dec 13, 2025
Contributor
joebowbeer
left a comment
joebowbeer
left a comment
There was a problem hiding this comment.
LGTM
Btw, you don't need to bump the version unless you want to preserve the previous snapshot.
3067debb9dae42c747023bcf99beb4be287da7e6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the libpd's oboe jni, that ignored the sample rate requested from the app.
This has been fixed upstream, and this PR imports this fix.
Moreover, it is important we provide a "Default" sample rate setting in the preferences system, because on some devices it's preferable to stick to the hardware sample rate. This PR also takes care of it.
Version has been bumped to 1.4.1, in order to trigger a new snapshot.