Skip to content

fix samplerate handling #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joebowbeer merged 2 commits into from
Dec 13, 2025
Merged

fix samplerate handling #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e135d8
import samplerate fix in libpd, add 'Default' samplerate pref
Ant1r Dec 13, 2025
d66310f
version 1.4.1
Ant1r Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PdCore/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ allprojects {
// These are specific to PdCore, but nexusPublishing needs them here:
// https://github.com/gradle-nexus/publish-plugin/issues/84
group = 'io.github.libpd.android'
version = '1.4.0-SNAPSHOT'
version = '1.4.1-SNAPSHOT'

// Create a Sonatype user token for these environment variables:
// export ORG_GRADLE_PROJECT_sonatypeUsername="<tokenUsername>"
Expand Down
8 changes: 5 additions & 3 deletions PdCore/pd-core/src/main/java/org/puredata/android/service/PdPreferences.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,14 @@ public static void initPreferences(Context context) {
SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(context);
if (!prefs.contains(res.getString(R.string.pref_key_srate))) {
SharedPreferences.Editor editor = prefs.edit();
int srate = PdBase.suggestSampleRate();
editor.putString(res.getString(R.string.pref_key_srate), "" + ((srate > 0) ? srate : AudioParameters.suggestSampleRate()));

// init samplerate and audio device prefs to "Default":
editor.putString(res.getString(R.string.pref_key_srate), res.getStringArray(R.array.srate_values)[0]);
editor.putString(res.getString(R.string.pref_key_indevice), res.getStringArray(R.array.indevice_values)[0]);
editor.putString(res.getString(R.string.pref_key_outdevice), res.getStringArray(R.array.outdevice_values)[0]);

int nic = PdBase.suggestInputChannels();
editor.putString(res.getString(R.string.pref_key_inchannels), "" + ((nic > 0) ? nic : AudioParameters.suggestInputChannels()));
editor.putString(res.getString(R.string.pref_key_outdevice), res.getStringArray(R.array.outdevice_values)[0]);
int noc = PdBase.suggestOutputChannels();
editor.putString(res.getString(R.string.pref_key_outchannels), "" + ((noc > 0) ? noc : AudioParameters.suggestOutputChannels()));
editor.commit();
Expand Down
2 changes: 1 addition & 1 deletion PdCore/pd-core/src/main/jni/libpd
Open in desktop
Submodule libpd updated 3 files
+4 −2 jni/oboe/OboeEngine.cpp
+1 −0 jni/oboe/OboeEngine.h
+2 −2 jni/oboe/z_jni_oboe.cpp
2 changes: 2 additions & 0 deletions PdCore/pd-core/src/main/res/values/audio.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<string-array name="srate_labels">
<item>Default</item>
<item>8000Hz</item>
<item>11025Hz</item>
<item>16000Hz</item>
Expand All @@ -10,6 +11,7 @@
<item>48000Hz</item>
</string-array>
<string-array name="srate_values">
<item>-1</item>
<item>8000</item>
<item>11025</item>
<item>16000</item>
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ allprojects {

```gradle
dependencies {
implementation 'io.github.libpd.android:pd-core:1.4.0-SNAPSHOT'
implementation 'io.github.libpd.android:pd-core:1.4.1-SNAPSHOT'
}
```

Expand Down
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ ext {
compileSdk = 34
androidxLegacySupportVersion = '1.0.0'
ndkVersion = libs.versions.ndk.get()
pdCoreVersion = '1.4.0-SNAPSHOT' // Must match version in PdCore/build.gradle
pdCoreVersion = '1.4.1-SNAPSHOT' // Must match version in PdCore/build.gradle
}