-
Notifications
You must be signed in to change notification settings - Fork 9
More bibdb data #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
More bibdb data #527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pragmatiskt isärhållning med namespace, skulle gärna se att när vi nu myntar nya "officiella" URI:er för organisationer t.ex. att vi signalerar nån sorts disclaimer för kontexten/datasetet så att inte extern användning drar iväg på dessa former.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from what I can tell!
|
||
# https://git.kb.se/libris/bibdb/-/blob/develop/libdb/models.py#L262 | ||
:natbib a idkbse_bibdb:LibraryType ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that came to mind: What's the convention for enums, should they be capitalized or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are mixing a bit 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried to keep it simple and use the exact string from BIBDB so that we can match them directly 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I thought!
Tänkte du här eller? |
Map more data from bibdb.
bibdb:namespace
. Some of them might be moved to main KBV later.TODO:
Examples: