-
Notifications
You must be signed in to change notification settings - Fork 9
More bibdb data #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
olovy
wants to merge
33
commits into
develop
Choose a base branch
from
feature/lws-341-more-bibdb-data
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
More bibdb data #527
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
d13ed0c
feat(bibdb): Add ILS search URIs
olovy 843f010
Add bibdb:templateUri
olovy 0a0e9ea
Add bibdb:eodUri
olovy cfbfb1f
Add bibdb prefix to context
olovy 8bf0f82
Remove stray 4
lrosenstrom 5763221
FILTER ils
olovy f7ab563
WIP: Add address
olovy 7a937ad
Add address
olovy e53e6f3
Add library types
olovy 51e729e
Fix context in bibdb_datasets.py
olovy 99fb171
Remove additional debugging in datacompiler.py
olovy 58a8376
Add reference for library types
olovy b1fbfab
Fix labels for LibraryTypes
olovy 8fb5f9f
Add contact types
olovy fbd4737
WIP: Add organization
olovy 66428d1
Add organization
olovy c7060b7
Fix empty nameByLang en
olovy 52d483a
Add linkresolver
olovy ea8e5b9
Add bibdb:openingHours
olovy baaa61d
Add latitude/longitude
olovy 629fd64
Add LOPAC stuff
olovy 8db4c7c
Add library sub type
olovy 808b888
Add label for bibdb:openingHours
olovy 109f8da
Fix library sub type URIs
olovy c52b1e3
Update lenses
olovy bee9ea6
Add itemStatusUri
olovy 556a7c3
Add bibdb:DisplayMode. Fix context mappings
olovy e4299eb
Fix context
olovy 272fb97
Fix address filtering
olovy 734d34f
Re-add stray comma
olovy 6c7124b
Fix ILS filter
olovy 4b43bb9
Add bibdb:PostalAddress-cards
olovy c2b684f
Add bibdb:PostalAddress-cards
olovy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that came to mind: What's the convention for enums, should they be capitalized or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are mixing a bit 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried to keep it simple and use the exact string from BIBDB so that we can match them directly 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I thought!