Remove REQUIRED from find_dependency.#35
Merged
LTLA merged 2 commits intolibscran:masterfrom Apr 22, 2026
Merged
Conversation
The purpose of find_dependency is to propagate REQUIRED-ness from the caller into dependencies, if required. That is, find_package(libscran_umappp QUIET) should make the inner search for Eigen3 itself QUIET, but putting REQUIRED there breaks this. Also fixed the order to exactly match the find_package block: https://github.com/BillyONeal/umappp/blob/8a6efdf0b5be73310fc079640127072b99332f75/CMakeLists.txt#L25-L30
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Apr 17, 2026
This was referenced Apr 17, 2026
Merged
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Collaborator
|
Makes sense to me, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of find_dependency is to propagate REQUIRED-ness from the caller into dependencies, if required.
That is, find_package(libscran_umappp QUIET) should make the inner search for Eigen3 itself QUIET, but putting REQUIRED there breaks this.
Also fixed the order to exactly match the find_package block:
umappp/CMakeLists.txt
Lines 25 to 30 in 8a6efdf