Fix DirectInput controllers when video driver is disabled - #16207
Open
connorjclark wants to merge 1 commit into
Open
Fix DirectInput controllers when video driver is disabled#16207connorjclark wants to merge 1 commit into
connorjclark wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In SDL2, building without the video backend causes DirectInput controllers to not work.
The fix is to fallback to a non-exclusive mode when a window handle is not present.
I tested this change in SDL2 and it worked for me, but I saw the code looks very similar in SDL3. I didn't actually build this in SDL3 though as I'm not currently setup for it.
Existing Issue(s)