Skip to content

Fix DirectInput controllers when video driver is disabled #16207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
connorjclark wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

Fix DirectInput controllers when video driver is disabled #16207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/joystick/windows/SDL_dinputjoystick.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,10 +791,13 @@ bool SDL_DINPUT_JoystickOpen(SDL_Joystick *joystick, JoyStick_DeviceData *joysti
}

/* Acquire shared access. Exclusive access is required for forces,
* though. */
* though. But if there's no window handle (b/c the video driver
* is disabled) use non-exclusive and give up forces rather than
* fail to open.
*/
result =
IDirectInputDevice8_SetCooperativeLevel(joystick->hwdata->InputDevice, SDL_HelperWindow,
DISCL_EXCLUSIVE |
(SDL_HelperWindow ? DISCL_EXCLUSIVE : DISCL_NONEXCLUSIVE) |
DISCL_BACKGROUND);
if (FAILED(result)) {
return SetDIerror("IDirectInputDevice8::SetCooperativeLevel", result);
Expand Down