fix: avoid race condition in retro controller analysis loading#2756
Open
lacostej wants to merge 1 commit intolichess-org:mainfrom
Open
fix: avoid race condition in retro controller analysis loading#2756lacostej wants to merge 1 commit intolichess-org:mainfrom
lacostej wants to merge 1 commit intolichess-org:mainfrom
Conversation
Register the lastAnalysisEvent listener before calling requestAnalysis to prevent missing events that arrive between the request and listener registration. Also check if analysis already completed before waiting. Fixes lichess-org#2750
Contributor
Author
|
Note: I have to test it a bit more. |
lacostej
added a commit
to lacostej/mobile
that referenced
this pull request
Mar 14, 2026
Move connectedStream and stream listener registration before `await _socketClient.firstConnection` in broadcast and TV controllers to avoid missing reconnection events during the initial connection. Similar pattern to the race condition fixed in RetroController (lichess-org#2756).
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2750
"Learn from your mistakes" can get stuck loading due to a race condition in
RetroController.build():lastAnalysisEventlistener was registered afterrequestAnalysis()returnedThe fix:
requestAnalysis()so no events are missedValueNotifier's current value) and process it immediatelyTest plan