External 3D Asset Rendering#117
Conversation
|
Please add a test .mcap file to showcase the feature. You can use the example models linked here: #71 |
jdsika
left a comment
jdsika
left a comment
There was a problem hiding this comment.
Add .mcap to test feature
myemural
force-pushed
the
feat/3d-model-loading
branch
from
5bb252c to
2e6052a
Compare
@jdsika I added example mcap and model file. Also updated README. Can you please recheck and approve the PR? |
|
I think the path should be relative to the application executable? Instructions should not be Linux/Windows specific. Who did the internal review as I do not see review comments from someone else? |
| color, | ||
| modelCacheMap.get(mapKey)!, | ||
| "", | ||
| modelCacheMap.get(mapKey), |
There was a problem hiding this comment.
Did you check if the traffic lights are still working, why this change?
There was a problem hiding this comment.
Yes I checked it:
This change is coming from function signature change of objectToModelPrimitive.
| ]; | ||
|
|
||
| const modelPathKey = obj.model_reference; | ||
| if (!modelCache.has(modelPathKey) && modelPathKey.startsWith("/")) { |
There was a problem hiding this comment.
pretty sure that something like this is not working for Linux <-> Windows "/"
There was a problem hiding this comment.
Done, but needs to be checked from Windows platform.
| 1, | ||
| 1, | ||
| { r: 0, g: 0, b: 0, a: 0 }, | ||
| "file://" + movingObject.model_reference, // Should be absolute path |
There was a problem hiding this comment.
Check functionality Windows <-> Linux
There was a problem hiding this comment.
Done, but needs to be checked from Windows platform.
myemural
force-pushed
the
feat/3d-model-loading
branch
from
ff16e58 to
970c706
Compare
3 participants
This item is related to loading 3D assets for moving objects if
model_referencefield of these moving objects are filled with 3D model path.IMPORTANT NOTE: You should run Lichtblick with
--allow-file-access-from-filesoption to properly load a 3D asset from your local. Example:Example Screenshots
Bounding box and 3D model settings are on:
Only bounding box setting is on:
Only 3D model setting is on:
The console error message when model loading is failed:
