Skip to content

Added Pipeline for LSM and PSOCT Data#83

Draft
calvinchai wants to merge 137 commits into
mainfrom
lsm-features
Draft

Added Pipeline for LSM and PSOCT Data#83
calvinchai wants to merge 137 commits into
mainfrom
lsm-features

Conversation

@calvinchai

Copy link
Copy Markdown
Contributor

No description provided.

…and rename spool_file to spool_data for clarity
# Conflicts:
#	linc_convert/modalities/lsm/__init__.py
Updated the Dockerfile to install all dependencies and set the entrypoint to use Poetry.
Refactor Dockerfile to use multi-stage builds for better dependency management and security practices.
Comment thread linc_convert/modalities/lsm/single_volume.py Outdated
Comment thread linc_convert/modalities/lsm/strip.py Outdated
Comment thread linc_convert/modalities/lsm/single_volume.py
Comment thread linc_convert/modalities/lsm/single_volume.py
Comment thread linc_convert/modalities/lsm/single_volume.py Outdated
Comment thread linc_convert/modalities/lsm/single_volume.py
Comment thread linc_convert/modalities/lsm/single_volume.py Outdated
Comment thread linc_convert/utils/io/spool.py Outdated
Comment thread linc_convert/modalities/lsm/single_volume.py Outdated
Comment thread .github/workflows/docker-build.yml Outdated
Comment thread linc_convert/utils/io/spool.py Outdated
Comment thread linc_convert/modalities/lsm/strip.py
Comment thread tests/test_stitch.py

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like tests/test_stitch.py and tests/test_utils_stitch.py are effectively the same file for the PS-OCT pipeline with slightly different formatting.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So one of them can be deleted.

@kabilar kabilar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the LSM changes and package changes (docker, pyproject, etc.). And fixed the CI failures. I will add the human LSM conversion pipeline on top of these changes.

@kabilar kabilar mentioned this pull request Jun 30, 2026
2 tasks
@kabilar

kabilar commented Jul 1, 2026

Copy link
Copy Markdown
Member

If this pull request is merged in, it first needs to be rebased to main since #88 was merged. Moving this pull request to Draft for now.

@kabilar
kabilar marked this pull request as draft July 1, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants