Implemented doThen method to chain ConnectionPoolListener

[asontireddy]

Motivation:

By implementing the doThen method, we can able to chain the ConnectionPoolListeners, which makes it easier to use

Modifications:

• created a new method doThen() which accepts ConnectionPoolListener and returns the new ConnectionPoolListener

Result:

• Closes #5159
• User can now chain more than one listener

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[asontireddy]

@trustin Can you please go through the changes I have made and let me know if I am going in the right direction? Also, the project is building fine locally but I am getting some errors when I run existing tests, Can you please help me resolve those errors, so that I can write a unit test for this change?

[asontireddy]

Hi Guys, also I signed the CLA, but it is still showing as pending, Is there anything else that I need to do in that area so that action passes?

[jrhee17]

Hi Guys, also I signed the CLA, but it is still showing as pending, Is there anything else that I need to do in that area so that action passes?

Did you sign the CLA with the same email used for the commit?

[jrhee17]

Thanks! Left some minor comments 👍

[jrhee17]

Suggested change

	default ConnectionPoolListener doThen(ConnectionPoolListener anotherConnectionPoolListener) {
	default ConnectionPoolListener andThen(ConnectionPoolListener anotherConnectionPoolListener) {

[jrhee17]

I think the expectation is that this#connectionOpen is called, and then anotherConnectionPoolListener#connectionOpen is called (hence "chained").

Can you also add a test to confirm this behavior?

Suggested change

	anotherConnectionPoolListener.connectionOpen(protocol, remoteAddr, localAddr, attrs);
	connectionOpen(protocol, remoteAddr, localAddr, attrs);
	anotherConnectionPoolListener.connectionOpen(protocol, remoteAddr, localAddr, attrs);

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.25%. Comparing base (863e27c) to head (bb3b110).
Report is 688 commits behind head on main.

Files with missing lines	Patch %	Lines
...inecorp/armeria/client/ConnectionPoolListener.java	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #5166   +/-   ##
=========================================
  Coverage     74.25%   74.25%           
- Complexity    19825    19828    +3     
=========================================
  Files          1699     1699           
  Lines         73046    73052    +6     
  Branches       9357     9357           
=========================================
+ Hits          54239    54245    +6     
- Misses        14371    14374    +3     
+ Partials       4436     4433    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

🔍 Build Scan® (commit: bb3b110)

Job name	Status	Build Scan®
build-windows-latest-jdk-19	❌ (failure)	https://ge.armeria.dev/s/bzi5av4ryquew
build-self-hosted-jdk-8	✅	https://ge.armeria.dev/s/zposonpi2etym
build-self-hosted-jdk-19-snapshot-blockhound	✅	https://ge.armeria.dev/s/jfx6madmmrg7a
build-self-hosted-jdk-17-min-java-17-coverage	✅	https://ge.armeria.dev/s/azydgudt2wpig
build-self-hosted-jdk-17-min-java-11	✅	https://ge.armeria.dev/s/qeydbyfqkiqes
build-self-hosted-jdk-17-leak	✅	https://ge.armeria.dev/s/b2oysm2jb4nys
build-self-hosted-jdk-11	✅	https://ge.armeria.dev/s/p5mocnjo7zvg2
build-macos-12-jdk-19	✅	https://ge.armeria.dev/s/7siskmetvus5k

[Ivan-Montes]

Hi @jrhee17, I would like to contribute to this solution if you agree.

[minwoox]

Let me close this PR since it's not updated and superseded by #6207