Skip to content

Implemented doThen method to chain ConnectionPoolListener #5166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asontireddy wants to merge 1 commit into from
Closed

Implemented doThen method to chain ConnectionPoolListener #5166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions core/src/main/java/com/linecorp/armeria/client/ConnectionPoolListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
import io.micrometer.core.instrument.MeterRegistry;
import io.netty.util.AttributeMap;

import static java.util.Objects.requireNonNull;

/**
* Listens to the client connection pool events.
*/
Expand Down Expand Up @@ -122,4 +124,19 @@ void connectionClosed(SessionProtocol protocol,
default ConnectionPoolListener unwrap() {
return this;
}

default ConnectionPoolListener doThen(ConnectionPoolListener anotherConnectionPoolListener) {

@jrhee17 jrhee17 Sep 4, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default ConnectionPoolListener doThen(ConnectionPoolListener anotherConnectionPoolListener) {
default ConnectionPoolListener andThen(ConnectionPoolListener anotherConnectionPoolListener) {

requireNonNull(anotherConnectionPoolListener, "anotherConnectionPoolListener");
return new ConnectionPoolListener() {
@Override
public void connectionOpen(SessionProtocol protocol, InetSocketAddress remoteAddr, InetSocketAddress localAddr, AttributeMap attrs) throws Exception {
anotherConnectionPoolListener.connectionOpen(protocol, remoteAddr, localAddr, attrs);

@jrhee17 jrhee17 Sep 4, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the expectation is that this#connectionOpen is called, and then anotherConnectionPoolListener#connectionOpen is called (hence "chained").

Can you also add a test to confirm this behavior?

Suggested change
anotherConnectionPoolListener.connectionOpen(protocol, remoteAddr, localAddr, attrs);
connectionOpen(protocol, remoteAddr, localAddr, attrs);
anotherConnectionPoolListener.connectionOpen(protocol, remoteAddr, localAddr, attrs);

}

@Override
public void connectionClosed(SessionProtocol protocol, InetSocketAddress remoteAddr, InetSocketAddress localAddr, AttributeMap attrs) throws Exception {
anotherConnectionPoolListener.connectionClosed(protocol, remoteAddr, localAddr, attrs);
}
};
}
}