(Thrift Field Masker Pt1) Remove redundant thrift files - #6310
Merged
Conversation
Contributor
jrhee17
marked this pull request as ready for review
July 10, 2025 03:03
ikhoon
approved these changes
Jul 15, 2025
| from "${rootProject.projectDir}/thrift/thrift0.13/src/test/thrift" | ||
| into "${rootProject.projectDir}/thrift/thrift0.9/gen-src/test/thrift" | ||
| filter { String line -> | ||
| line.replaceAll('i8', 'byte') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
While adding test cases for thrift, I found it inconvenient to update thrift messages for each module (thrift0.9, thrift0.12, and thrift 0.13).
When diffing each file, the only difference I found for thrift0.9 was
i8was used instead ofbyte.I propose that thrift0.13 IDL definitions are used across all versions.
To accomodate thrift0.9, a new
thrift9ifytask is added.Modifications:
Result: