Skip to content

(Thrift Field Masker Pt1) Remove redundant thrift files - #6310

Merged
jrhee17 merged 2 commits into
line:mainfrom
jrhee17:feat/thrift-log-maskers-tproto-part1
Jul 15, 2025
Merged

(Thrift Field Masker Pt1) Remove redundant thrift files#6310
jrhee17 merged 2 commits into
line:mainfrom
jrhee17:feat/thrift-log-maskers-tproto-part1

Conversation

@jrhee17

@jrhee17 jrhee17 commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

Motivation:

While adding test cases for thrift, I found it inconvenient to update thrift messages for each module (thrift0.9, thrift0.12, and thrift 0.13).
When diffing each file, the only difference I found for thrift0.9 was i8 was used instead of byte.

I propose that thrift0.13 IDL definitions are used across all versions.
To accomodate thrift0.9, a new thrift9ify task is added.

Modifications:

  • Removed thrift IDL definitions for thrift0.9, thrift0.12.

Result:

  • It is easier to define thrift messages for tests

@jrhee17 jrhee17 added this to the 1.33.0 milestone Jul 10, 2025
@jrhee17
jrhee17 marked this pull request as ready for review July 10, 2025 03:03

@minwoox minwoox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

from "${rootProject.projectDir}/thrift/thrift0.13/src/test/thrift"
into "${rootProject.projectDir}/thrift/thrift0.9/gen-src/test/thrift"
filter { String line ->
line.replaceAll('i8', 'byte')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. 👍

@jrhee17
jrhee17 merged commit 835ccaf into line:main Jul 15, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants