Repository navigation
Avoid making useless silence - #826
Merged
vincent-olivert-riera merged 2 commits intoNov 13, 2026
Merged
vincent-olivert-riera merged 2 commits into
vincent-olivert-riera merged 2 commits into
Conversation
We have added a validation to SilenceSerializer to require meaningful "service" or "project" matchers when users create a new Silence or update an existing one.
We have added a validation step requiring that Silence created by regular users must affect at least one service or project on Promgen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current validations of Promgen's Silence creating/updating feature still have some defect. It allows normal Promgen users to make useless or ambiguous Silences that affect nothing on Promgen. Additionally, these Silences could cause problem to Alerts on Alertmanager that were not managed by Promgen.
This PR will add more validations to avoid those issues.