Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions promgen/errors.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,6 @@ class SilenceError(ValidationErrorEnum):
STARTENDMISMATCH = _("Start time and end time are mismatched.")
NOMATCHER = _("Missing matchers for silence.")
NOSERVICEORPROJECTMATCHER = _("Silence must include a service or project matcher.")
NO_MEANINGFUL_SERVICE_OR_PROJECT_MATCHER = _(
"Either meaningful service or project matchers are required."
)
32 changes: 25 additions & 7 deletions promgen/proxy.py
Original file line number Diff line number Diff line change
Expand Up @@ -385,9 +385,7 @@ def post(self, request):
)


def get_uneditable_obj_by_silence_matchers(matchers, user):
affected_projects, affected_services = get_affected_obj_by_matchers(matchers)

def get_uneditable_for_user(affected_projects, affected_services, user):
uneditable_projects = models.Project.objects.none()
uneditable_services = models.Service.objects.none()

Expand Down Expand Up @@ -429,8 +427,25 @@ def post(self, request, *args, **kwargs):

# Check if the user has permission to silence the alert
if not request.user.is_superuser:
uneditable_projects, uneditable_services = get_uneditable_obj_by_silence_matchers(
serializer.data["matchers"], request.user
affected_projects, affected_services = get_affected_obj_by_matchers(
serializer.data["matchers"]
)

if not affected_projects.exists() and not affected_services.exists():
return JsonResponse(
{
"messages": [
{
"class": "alert alert-warning",
"message": _("Silence affects no projects or services."),
}
]
},
status=HTTPStatus.FORBIDDEN,
)

uneditable_projects, uneditable_services = get_uneditable_for_user(
affected_projects, affected_services, request.user
)
messages = []
for objs, label in [
Expand Down Expand Up @@ -501,8 +516,11 @@ def delete(self, request, silence_id):
# Check if the user has permission to delete the silence
if not request.user.is_superuser:
silence = response.json()
uneditable_projects, uneditable_services = get_uneditable_obj_by_silence_matchers(
silence.get("matchers", []), request.user
affected_projects, affected_services = get_affected_obj_by_matchers(
silence.get("matchers", [])
)
uneditable_projects, uneditable_services = get_uneditable_for_user(
affected_projects, affected_services, request.user
)
messages = []
for objs, label in [
Expand Down
11 changes: 11 additions & 0 deletions promgen/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,17 @@ def validate(self, data):
if not any(matcher["name"] in ["service", "project"] for matcher in data["matchers"]):
raise errors.SilenceError.NOSERVICEORPROJECTMATCHER.error()

# Either meaningful service or project matchers are required
meaningful_service_matcher = False
meaningful_project_matcher = False
for matcher in data["matchers"]:
if matcher["name"] == "service" and matcher["value"] not in [".*", ".+", ""]:
meaningful_service_matcher = True
if matcher["name"] == "project" and matcher["value"] not in [".*", ".+", ""]:
meaningful_project_matcher = True
if not (meaningful_service_matcher or meaningful_project_matcher):
raise errors.SilenceError.NO_MEANINGFUL_SERVICE_OR_PROJECT_MATCHER.error()

if data.get("duration"):
# No further validation is required if only duration is set
return data
Expand Down