fix: Incomplete URL substring sanitization Unvalidated Redirects and Forwards #736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
patched(fix) for #735
To fix the problem, we should parse the URL and check the hostname to ensure it matches the expected domain. This can be done using the
urlparse
function from theurllib.parse
module. We will extract the hostname from the URL and check if it ends with the expected domain."-example.com" in result
with a more robust check that parses the URL and verifies the hostname.urlparse
function to extract the hostname and check if it ends with the expected domain.