Skip to content

fix: Incomplete URL substring sanitization Unvalidated Redirects and Forwards #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: Incomplete URL substring sanitization Unvalidated Redirects and Forwards #736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/integration/domains/test_slave_domains.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@
result = exec_test_command(
BASE_CMD + ["list", "--text", "--no-header"]
).stdout.decode()
assert "-example.com" in result
from urllib.parse import urlparse
parsed_url = urlparse(result)
assert parsed_url.hostname and parsed_url.hostname.endswith("-example.com")

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High test

The string
-example.com
Loading
may be at an arbitrary position in the sanitized URL.


@pytest.mark.skip(reason="BUG 872")
Expand Down
Loading