Skip to content

upcoming: [M3-9989, M3-9919] - Add beta ACLP contextual alerts to Alerts tab on Linode details page #12236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented May 16, 2025

Description 📝

Add beta ACLP contextual alerts to the Alerts tab on the Linode details page.

Changes 🔄

  • Added beta ACLP contextual alerts to the Alerts tab on the Linode details page.
  • Renamed legacy "Alerts" tab heading to Default Alerts

Target release date 🗓️

N/A

Preview 📷

Before After
Screenshot 2025-05-16 at 4 59 43 PM Screenshot 2025-05-16 at 4 57 47 PM Without MSW: Screenshot 2025-05-16 at 4 58 41 PM

How to test 🧪

Prerequisites

  • Enable MSW and the ACLP Integration feature flag

Verification steps

  • Confirm that the beta ACLP alerts are displayed when switching to the Alerts beta mode
  • Verify legacy "Alerts" tab heading is now Default Alerts
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@pmakode-akamai pmakode-akamai self-assigned this May 16, 2025
@pmakode-akamai pmakode-akamai added Linodes Dealing with the Linodes section of the app ACLP Integration CI (Cloud Interfaces) Support for CC (Core Compute) CloudPulse Integration labels May 16, 2025
@pmakode-akamai pmakode-akamai marked this pull request as ready for review May 16, 2025 11:32
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner May 16, 2025 11:32
@pmakode-akamai pmakode-akamai requested review from carrillo-erik, bill-akamai and jaalah-akamai and removed request for a team May 16, 2025 11:32
@pmakode-akamai pmakode-akamai added the Add'tl Approval Needed Waiting on another approval! label May 19, 2025
@pmakode-akamai pmakode-akamai changed the title upcoming: [M3-9989] - Add beta ACLP contextual alerts to Alerts tab on Linode details page upcoming: [M3-9989, M3-9919] - Add beta ACLP contextual alerts to Alerts tab on Linode details page May 19, 2025
@@ -219,14 +221,15 @@ export const LinodeSettingsAlertsPanel = (props: Props) => {
].filter((thisAlert) => !thisAlert.hidden);

const generalError = hasErrorFor('none');
const alertsHeading = flags.aclpIntegration ? 'Default Alerts' : 'Alerts';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a new heading for legacy alerts based on the UX mocks.

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 596 passing tests on test run #11 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing596 Passing4 Skipped120m 49s

Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches mocks - looks good

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager May 20, 2025
@jaalah-akamai jaalah-akamai merged commit 0a19391 into linode:develop May 20, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager May 20, 2025
@pmakode-akamai pmakode-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACLP Integration CI (Cloud Interfaces) Support for CC (Core Compute) CloudPulse Integration Approved Multiple approvals and ready to merge! Linodes Dealing with the Linodes section of the app
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

4 participants