-
Notifications
You must be signed in to change notification settings - Fork 379
upcoming: [M3-9989, M3-9919] - Add beta ACLP contextual alerts to Alerts tab on Linode details page #12236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jaalah-akamai
merged 6 commits into
linode:develop
from
pmakode-akamai:M3-9989-add-beta-aclp-alerts-on-linode-details-page
May 20, 2025
Merged
upcoming: [M3-9989, M3-9919] - Add beta ACLP contextual alerts to Alerts tab on Linode details page #12236
jaalah-akamai
merged 6 commits into
linode:develop
from
pmakode-akamai:M3-9989-add-beta-aclp-alerts-on-linode-details-page
May 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the Linode details page
bill-akamai
reviewed
May 16, 2025
packages/manager/.changeset/pr-12236-upcoming-features-1747395107850.md
Outdated
Show resolved
Hide resolved
bill-akamai
approved these changes
May 16, 2025
pmakode-akamai
commented
May 19, 2025
@@ -219,14 +221,15 @@ export const LinodeSettingsAlertsPanel = (props: Props) => { | |||
].filter((thisAlert) => !thisAlert.hidden); | |||
|
|||
const generalError = hasErrorFor('none'); | |||
const alertsHeading = flags.aclpIntegration ? 'Default Alerts' : 'Alerts'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a new heading for legacy alerts based on the UX mocks.
4 tasks
Cloud Manager UI test results🎉 596 passing tests on test run #11 ↗︎
|
jaalah-akamai
approved these changes
May 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches mocks - looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ACLP Integration
CI (Cloud Interfaces) Support for CC (Core Compute) CloudPulse Integration
Approved
Multiple approvals and ready to merge!
Linodes
Dealing with the Linodes section of the app
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add beta ACLP contextual alerts to the Alerts tab on the Linode details page.
Changes 🔄
Default Alerts
Target release date 🗓️
N/A
Preview 📷
How to test 🧪
Prerequisites
ACLP Integration
feature flagVerification steps
Default Alerts
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅