[LFXV2-1211] Add pod annotations and labels support by bramwelt · Pull Request #25 · linuxfoundation/lfx-v2-auth-service

bramwelt · 2026-03-06T18:43:53Z

Summary

Add podAnnotations and podLabels values to Helm chart (default empty)
Update deployment template to render pod-level annotations and labels

🤖 Generated with Claude Code

🤖 Generated with [Claude Code](https://claude.com/claude-code) Issue: LFXV2-1211 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>

coderabbitai · 2026-03-06T18:44:12Z

Warning

Rate limit exceeded

@bramwelt has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 58 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 02d103c0-9362-434a-a0c5-e190f0ee0604

📥 Commits

Reviewing files that changed from the base of the PR and between b05b87d and a903429.

📒 Files selected for processing (1)

charts/lfx-v2-auth-service/values.yaml

Walkthrough

This pull request adds support for configurable pod annotations and pod labels to the LFX v2 auth service Helm chart. Two new empty configuration keys are introduced in values.yaml, and the deployment template is updated to conditionally render these values when provided.

Changes

Cohort / File(s)	Summary
Helm Chart Configuration `charts/lfx-v2-auth-service/templates/deployment.yaml`, `charts/lfx-v2-auth-service/values.yaml`	Added `podAnnotations` and `podLabels` configuration support to the Deployment template with conditional rendering blocks. Initialized both keys as empty maps in values.yaml.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding pod annotations and labels support to the Helm chart, which matches the changeset.
Description check	✅ Passed	The description is directly related to the changeset, outlining the addition of podAnnotations and podLabels to the Helm chart and deployment template updates.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch tbramwell/LFXV2-1211-pod-annotations-labels

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR adds support for pod-level annotations and labels in the lfx-v2-auth-service Helm chart, allowing users to inject custom metadata (e.g., for Prometheus scraping, Istio sidecars, or workload grouping) into deployed pods without modifying the chart templates directly.

Changes:

Adds podAnnotations and podLabels as empty-map defaults in values.yaml
Updates deployment.yaml to conditionally render those annotations and labels onto the pod template metadata

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`charts/lfx-v2-auth-service/values.yaml`	Adds `podAnnotations: {}` and `podLabels: {}` top-level values
`charts/lfx-v2-auth-service/templates/deployment.yaml`	Renders `podAnnotations` under `template.metadata.annotations` and merges `podLabels` into `template.metadata.labels`

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-06T18:45:32Z

charts/lfx-v2-auth-service/values.yaml


+podAnnotations: {}
+


Every other top-level value in values.yaml is preceded by a descriptive comment explaining its purpose (e.g., # replicaCount is the number of replicas for the deployment, # service is the configuration for the Kubernetes service). The new podAnnotations and podLabels keys are missing these explanatory comments, breaking the consistent documentation convention throughout this file. Please add comments such as # podAnnotations are additional annotations to add to the pod and # podLabels are additional labels to add to the pod.

Suggested change

podAnnotations: {}

# podAnnotations are additional annotations to add to the pod

podAnnotations: {}

# podLabels are additional labels to add to the pod

coderabbitai

🧹 Nitpick comments (1)

charts/lfx-v2-auth-service/values.yaml (1)
7-9: Consider adding inline comments for consistency.

Other configuration keys in this file have descriptive comments (e.g., replicaCount, image.tag). Adding brief comments for podAnnotations and podLabels would maintain documentation consistency.
📝 Suggested documentation
+# podAnnotations are additional annotations to add to the pod
 podAnnotations: {}

+# podLabels are additional labels to add to the pod
 podLabels: {}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@charts/lfx-v2-auth-service/values.yaml` around lines 7 - 9, Add brief inline
comments above the podAnnotations and podLabels keys to match the file's
documentation style: describe purpose (annotations/labels applied to pods), note
typical use-cases (e.g., inject sidecars, metrics, environment-specific labels),
and show that empty map means none by default; update the entries named
podAnnotations and podLabels accordingly so they mirror the style used for
replicaCount and image.tag.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@charts/lfx-v2-auth-service/values.yaml`:
- Around line 7-9: Add brief inline comments above the podAnnotations and
podLabels keys to match the file's documentation style: describe purpose
(annotations/labels applied to pods), note typical use-cases (e.g., inject
sidecars, metrics, environment-specific labels), and show that empty map means
none by default; update the entries named podAnnotations and podLabels
accordingly so they mirror the style used for replicaCount and image.tag.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d6c1e8d1-8c77-425f-87c3-ee24fe810aa8

📥 Commits

Reviewing files that changed from the base of the PR and between 9374f25 and b05b87d.

📒 Files selected for processing (2)

charts/lfx-v2-auth-service/templates/deployment.yaml
charts/lfx-v2-auth-service/values.yaml

🤖 Generated with [Claude Code](https://claude.com/claude-code) Issue: LFXV2-1211 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>

asithade

LGTM

Add pod annotations and labels support

b05b87d

🤖 Generated with [Claude Code](https://claude.com/claude-code) Issue: LFXV2-1211 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>

bramwelt requested a review from a team as a code owner March 6, 2026 18:43

Copilot AI review requested due to automatic review settings March 6, 2026 18:43

Copilot started reviewing on behalf of bramwelt March 6, 2026 18:44 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

coderabbitai bot reviewed Mar 6, 2026

View reviewed changes

Add usage comments for podAnnotations/podLabels

a903429

🤖 Generated with [Claude Code](https://claude.com/claude-code) Issue: LFXV2-1211 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>

asithade approved these changes Mar 6, 2026

View reviewed changes

bramwelt merged commit da0c7ea into main Mar 6, 2026
6 checks passed

bramwelt deleted the tbramwell/LFXV2-1211-pod-annotations-labels branch March 6, 2026 19:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LFXV2-1211] Add pod annotations and labels support#25

[LFXV2-1211] Add pod annotations and labels support#25
bramwelt merged 2 commits intomainfrom
tbramwell/LFXV2-1211-pod-annotations-labels

bramwelt commented Mar 6, 2026

Uh oh!

coderabbitai bot commented Mar 6, 2026 •

edited

Loading

Rate limit exceeded

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

coderabbitai bot left a comment

Uh oh!

asithade left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bramwelt commented Mar 6, 2026

Summary

Uh oh!

coderabbitai bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

asithade left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Mar 6, 2026 •

edited

Loading