Skip to content

[LFXV2-1211] Add pod annotations and labels support #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramwelt merged 2 commits into from
Mar 6, 2026
+19 −0
Merged

[LFXV2-1211] Add pod annotations and labels support #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b05b87d
Add pod annotations and labels support
bramwelt Mar 6, 2026
a903429
Add usage comments for podAnnotations/podLabels
bramwelt Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions charts/lfx-v2-auth-service/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,15 @@ spec:
app: {{ .Chart.Name }}
template:
metadata:
{{- with .Values.podAnnotations }}
annotations:
{{- toYaml . | nindent 8 }}
{{- end }}
labels:
app: {{ .Chart.Name }}
{{- with .Values.podLabels }}
{{- toYaml . | nindent 8 }}
{{- end }}
spec:
{{- if eq .Values.app.environment.USER_REPOSITORY_TYPE.value "authelia" }}
serviceAccountName: {{ .Chart.Name }}
Expand Down
12 changes: 12 additions & 0 deletions charts/lfx-v2-auth-service/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,18 @@
# replicaCount is the number of replicas for the deployment
replicaCount: 3

# podAnnotations are additional annotations applied to the pod template.
# Example:
# prometheus.io/scrape: "true"
# prometheus.io/port: "8080"
podAnnotations: {}

Comment on lines 6 to +12
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every other top-level value in values.yaml is preceded by a descriptive comment explaining its purpose (e.g., # replicaCount is the number of replicas for the deployment, # service is the configuration for the Kubernetes service). The new podAnnotations and podLabels keys are missing these explanatory comments, breaking the consistent documentation convention throughout this file. Please add comments such as # podAnnotations are additional annotations to add to the pod and # podLabels are additional labels to add to the pod.

Suggested change
podAnnotations: {}
# podAnnotations are additional annotations to add to the pod
podAnnotations: {}
# podLabels are additional labels to add to the pod

Copilot uses AI. Check for mistakes.
# podLabels are additional labels applied to the pod template.
# Example:
# team: platform
# environment: production
podLabels: {}

image:
repository: ghcr.io/linuxfoundation/lfx-v2-auth-service/server
# tag is the container image tag (overrides appVersion from Chart.yaml)
Expand Down