Skip to content

[LFXV2-1211] Add pod annotations and labels support#32

Merged
bramwelt merged 2 commits intomainfrom
tbramwell/LFXV2-1211-pod-annotations-labels
Mar 6, 2026
Merged

[LFXV2-1211] Add pod annotations and labels support#32
bramwelt merged 2 commits intomainfrom
tbramwell/LFXV2-1211-pod-annotations-labels

Conversation

@bramwelt
Copy link
Contributor

@bramwelt bramwelt commented Mar 6, 2026

Summary

  • Add podAnnotations and podLabels values to Helm chart (default empty)
  • Update deployment template to render pod-level annotations and labels

🤖 Generated with Claude Code

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Issue: LFXV2-1211
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
@bramwelt bramwelt requested a review from a team as a code owner March 6, 2026 18:44
Copilot AI review requested due to automatic review settings March 6, 2026 18:44
@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

Warning

Rate limit exceeded

@bramwelt has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 54 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9bc87101-c3a0-405d-a5fd-6f35cf9f9574

📥 Commits

Reviewing files that changed from the base of the PR and between 2c79e7e and caa993e.

📒 Files selected for processing (2)
  • charts/lfx-v2-mailing-list-service/templates/deployment.yaml
  • charts/lfx-v2-mailing-list-service/values.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch tbramwell/LFXV2-1211-pod-annotations-labels

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for custom pod-level annotations and labels on the Helm chart's Deployment template, allowing users to attach metadata (e.g., Prometheus scrape configs, Istio sidecar injection, Datadog tags) to pods without modifying the chart directly.

Changes:

  • Added podAnnotations and podLabels values (defaulting to empty maps) in values.yaml
  • Updated deployment.yaml template to conditionally render pod annotations and merge custom pod labels alongside the existing app label

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
charts/lfx-v2-mailing-list-service/values.yaml Adds podAnnotations: {} and podLabels: {} default values
charts/lfx-v2-mailing-list-service/templates/deployment.yaml Adds conditional rendering of pod annotations and labels from values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 15 to +17

podAnnotations: {}

Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The podAnnotations and podLabels values are missing descriptive comments, which is inconsistent with the rest of this file where every value has a # comment explaining its purpose (e.g., # replicaCount is the number of replicas for the deployment on line 13, # resources is the configuration for resource requests and limits on line 20). Please add comments like # podAnnotations are additional annotations to add to the pod template and # podLabels are additional labels to add to the pod template.

Suggested change
podAnnotations: {}
# podAnnotations are additional annotations to add to the pod template
podAnnotations: {}
# podLabels are additional labels to add to the pod template

Copilot uses AI. Check for mistakes.
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Issue: LFXV2-1211
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
Copy link
Contributor

@asithade asithade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bramwelt bramwelt merged commit f0591d2 into main Mar 6, 2026
6 checks passed
@bramwelt bramwelt deleted the tbramwell/LFXV2-1211-pod-annotations-labels branch March 6, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants