[LFXV2-1211] Add pod annotations and labels support#32
Conversation
🤖 Generated with [Claude Code](https://claude.com/claude-code) Issue: LFXV2-1211 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR adds support for custom pod-level annotations and labels on the Helm chart's Deployment template, allowing users to attach metadata (e.g., Prometheus scrape configs, Istio sidecar injection, Datadog tags) to pods without modifying the chart directly.
Changes:
- Added
podAnnotationsandpodLabelsvalues (defaulting to empty maps) invalues.yaml - Updated
deployment.yamltemplate to conditionally render pod annotations and merge custom pod labels alongside the existingapplabel
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/lfx-v2-mailing-list-service/values.yaml | Adds podAnnotations: {} and podLabels: {} default values |
| charts/lfx-v2-mailing-list-service/templates/deployment.yaml | Adds conditional rendering of pod annotations and labels from values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| podAnnotations: {} | ||
|
|
There was a problem hiding this comment.
The podAnnotations and podLabels values are missing descriptive comments, which is inconsistent with the rest of this file where every value has a # comment explaining its purpose (e.g., # replicaCount is the number of replicas for the deployment on line 13, # resources is the configuration for resource requests and limits on line 20). Please add comments like # podAnnotations are additional annotations to add to the pod template and # podLabels are additional labels to add to the pod template.
| podAnnotations: {} | |
| # podAnnotations are additional annotations to add to the pod template | |
| podAnnotations: {} | |
| # podLabels are additional labels to add to the pod template |
🤖 Generated with [Claude Code](https://claude.com/claude-code) Issue: LFXV2-1211 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
Summary
podAnnotationsandpodLabelsvalues to Helm chart (default empty)🤖 Generated with Claude Code