Skip to content

[LFXV2-1211] Add pod annotations and labels support #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramwelt merged 2 commits into from
Mar 6, 2026
Merged

[LFXV2-1211] Add pod annotations and labels support #32

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bb4b78
Add pod annotations and labels support
bramwelt Mar 6, 2026
caa993e
Add usage comments for podAnnotations/podLabels
bramwelt Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions charts/lfx-v2-mailing-list-service/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,15 @@ spec:
app: {{.Chart.Name}}
template:
metadata:
{{- with .Values.podAnnotations }}
annotations:
{{- toYaml . | nindent 8 }}
{{- end }}
labels:
app: {{.Chart.Name}}
{{- with .Values.podLabels }}
{{- toYaml . | nindent 8 }}
{{- end }}
spec:
# Use the configured service account for pod identity
serviceAccountName: {{ .Values.serviceAccount.name | default .Chart.Name }}
Expand Down
4 changes: 4 additions & 0 deletions charts/lfx-v2-mailing-list-service/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ image:
# replicaCount is the number of replicas for the deployment
replicaCount: 3

podAnnotations: {}

Comment on lines 15 to +21
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The podAnnotations and podLabels values are missing descriptive comments, which is inconsistent with the rest of this file where every value has a # comment explaining its purpose (e.g., # replicaCount is the number of replicas for the deployment on line 13, # resources is the configuration for resource requests and limits on line 20). Please add comments like # podAnnotations are additional annotations to add to the pod template and # podLabels are additional labels to add to the pod template.

Suggested change
podAnnotations: {}
# podAnnotations are additional annotations to add to the pod template
podAnnotations: {}
# podLabels are additional labels to add to the pod template

Copilot uses AI. Check for mistakes.
podLabels: {}

# resources is the configuration for resource requests and limits
resources:
limits:
Expand Down