fix: package information is not logged when command has not started TDE-1511 #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfouquet
requested review from
MDavidson17,
Wentao-Kuang,
amfage,
blacha and
schmidtnz
blacha
reviewed
May 22, 2025
schmidtnz
approved these changes
May 27, 2025
blacha
approved these changes
May 27, 2025
paulfouquet
deleted the
fix/package-information-is-not-logged-when-command-not-started
branch
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 28, 2025
🤖 I have created a release *beep* *boop* --- ## [4.15.0](v4.14.2...v4.15.0) (2025-05-28) ### Features * archive-setup command returning archive location based on source path TDE-1500 ([#1218](#1218)) ([018dc2a](018dc2a)) * compress and delete source files TDE-1482 ([#1216](#1216)) ([487fb30](487fb30)) ### Bug Fixes * package information is not logged when command has not started TDE-1511 ([#1226](#1226)) ([b62240c](b62240c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If a command fails to start (for example, missing arguments), the package information (for example,
"package":{"package":"@linzjs/argo-tasks","version":"v4.14.2","hash":"e8dbf80c51b7a2baf61b22eec49de7072c812223","buildId":""}) is not logged. Without this information, it makes it difficult to reproduce.Modification
Verification
Local test