Skip to content

fix: package information is not logged when command has not started TDE-1511 #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulfouquet merged 2 commits into from
May 27, 2025
Merged

fix: package information is not logged when command has not started TDE-1511 #1226

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
015e405
fix: package information is not logged when command has not started T…
paulfouquet May 22, 2025
7f9cac1
feat: log arguments before command starts
paulfouquet May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/commands/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { boolean, flag, option, optional, string } from 'cmd-ts';
import pLimit from 'p-limit';
import { fileURLToPath, pathToFileURL } from 'url';

import { CliInfo } from '../cli.info.ts';
import { registerFileSystem } from '../fs.register.ts';
import { logger, registerLogger } from '../log.ts';
import { isArgo } from '../utils/argo.ts';
Expand Down Expand Up @@ -34,7 +33,7 @@ export function registerCli(cli: { name: string }, args: { verbose?: boolean; co
registerLogger(args);
registerFileSystem(args);

logger.info({ package: CliInfo, cli: cli.name, args, isArgo: isArgo() }, 'Cli:Start');
logger.info({ cli: cli.name, args, isArgo: isArgo() }, 'Cli:Start');
}

/** Trim any extra special characters from the cli parser */
Expand Down
2 changes: 2 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@ process.env['AWS_NODEJS_CONNECTION_REUSE_ENABLED'] = '1';

import { run } from 'cmd-ts';

import { CliInfo } from './cli.info.ts';
import { cmd } from './commands/index.ts';
import { logger } from './log.ts';

const startTime = performance.now();
logger.info({ package: CliInfo }, 'Cli:Info');
run(cmd, process.argv.slice(2))
.then(() => {
logger.debug({ duration: performance.now() - startTime }, 'Command:Done');
Expand Down