[updates] specify python version #2933
Conversation
|
@arc64 this about the python version, btw |
partizipation
force-pushed
the
jp-2502-python-version
branch
from
fc5ebad to
ce4216b
Compare
m4ra
left a comment
m4ra
left a comment
There was a problem hiding this comment.
I would argue for writing a project.toml in the adhocracy-4 library and define the python version there, instead of constraining how developers should setup their virtualenv. Having a project.toml is also the standard fashion of publishing packages.
| @@ -0,0 +1 @@ | |||
| 3.11.6 No newline at end of file | |||
There was a problem hiding this comment.
Personally I use pyenv for versions, and pyenv for virtualenv, so this file points to the name of my pyenv's virtualenv, e.g named root which is located in .pyenv/versions/(venv) and that's why cannot be deleted with the make clean command. Hence, I don't think the solution here is inclusive enough approach.
There was a problem hiding this comment.
Could you say a little more? The make install command uses python3 -m venv $(VIRTUAL_ENV); so our clean script deletes this venv. What additional behavior would you expect?
There was a problem hiding this comment.
I create virtuanvs with pyenv virtualenv <name-of-venv> for all my projects, which places venvs in the home directory of /home/<user>/.pyenv/versions/<name-of-venv>
you bring some good points and i haven't really tried it myself. .python-version defaults my version in case i forget, so that is already quite helpful. |
|
with a docker build this should also be fixed tbh 🙈 |
If a developer is using pyenv, a new
.python-versionfile will force them onto the latest supported version.If not, they can now see in the README the supported version. Additionally, if they are on a non-supported version, when running
make installan warning will be printed to the console.@m4ra you mentioned
make cleandoesn't remove the venv directory when using pyenv, but it seems to be. Maybe this is no longer happening. If there are other issues with pyenv we could smooth out, maybe now would be a good time though, so let me know.edit: also added a note in README that macOS users will need to install libmagic