RPC changes for ingress proxy WHIP#1194
Conversation
|
| map<string, string> attributes = 15; | ||
| DisconnectReason disconnect_reason = 16; | ||
| repeated KindDetail kind_details = 18; | ||
| // indicates that subscriber subscribes to track of the participant can skip reference timestamps |
There was a problem hiding this comment.
I think this should not be in ParticipantInfo. This is sent as update. Other participants need not know this. Can we move this to the request where WHIP is created from ingress?
There was a problem hiding this comment.
The field is set in the WHIP handle but we need to broadcast it to all the subscribers. It is not the best place that the client sdk doesn't need to know this, but I can't find a better way to put the internal property so put it here. Do you have a suggestion place?
There was a problem hiding this comment.
ah got it, sorry my bad, yeah this needs to be known to subscribers, let me think
There was a problem hiding this comment.
Can we add a mode here so that it gets carried with track info? TrackInfo also goes to client and clients need not know about it, but I feel keeping it at track level is a bit better and we can make it an enum so that it is not a separate field.
Something like ONE_SPATIAL_LAYER_PER_STREAM_NO_RTCP_SENDER_REPORT or something like that (sorry, that name is horrible :-) )
cnderrauber
force-pushed
the
whip_notify
branch
from
71d39c3 to
fc52369
Compare
3 participants
sub_skip_reference_tsin participant info if the publisher's rtcp sr is incomplete for simulcast (will be set for obs whip session)