Skip to content

RPC changes for ingress proxy WHIP #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cnderrauber merged 6 commits into from
Sep 9, 2025
Merged

RPC changes for ingress proxy WHIP #1194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fa4fde3
Add rpc for ingress whip proxy
cnderrauber Sep 4, 2025
e5e965d
Merge remote-tracking branch 'origin/main' into whip_notify
cnderrauber Sep 4, 2025
90c3521
remove track stats
cnderrauber Sep 8, 2025
fc52369
use video layer mode for skip reference ts
cnderrauber Sep 8, 2025
3b4dbcb
compile error
cnderrauber Sep 8, 2025
3021e65
generated protobuf
github-actions[bot] Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions livekit/livekit_models.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion protobufs/livekit_models.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ message ParticipantInfo {
DisconnectReason disconnect_reason = 16;
repeated KindDetail kind_details = 18;

// NEXT_ID: 19
// NEXT_ID: 19
}

enum TrackType {
Expand Down Expand Up @@ -257,6 +257,7 @@ message VideoLayer {
MODE_UNUSED = 0;
ONE_SPATIAL_LAYER_PER_STREAM = 1;
MULTIPLE_SPATIAL_LAYERS_PER_STREAM = 2;
ONE_SPATIAL_LAYER_PER_STREAM_INCOMPLETE_RTCP_SR = 3;
}

// for tracks with a single layer, this should be HIGH
Expand Down
14 changes: 13 additions & 1 deletion protobufs/rpc/ingress.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,14 @@ service IngressHandler {
rpc ICERestartWHIPResource(ICERestartWHIPResourceRequest) returns (ICERestartWHIPResourceResponse) {
option (psrpc.options).topics = true;
};

rpc WHIPRTCConnectionNotify(WHIPRTCConnectionNotifyRequest) returns (google.protobuf.Empty) {
option (psrpc.options) = {
topics: true
topic_params: {
single_server: true;
}
};
};
}

message ListActiveIngressRequest {}
Expand Down Expand Up @@ -86,6 +93,11 @@ message ICERestartWHIPResourceResponse {
string etag = 2;
}

message WHIPRTCConnectionNotifyRequest {
string participant_id = 1;
bool closed = 2;
}

message StartIngressRequest {
livekit.IngressInfo info = 1;
string token = 2;
Expand Down
2 changes: 2 additions & 0 deletions protobufs/rpc/whip_signal.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ message WHIPCreateRequest {
livekit.StartSession start_session = 1;
string offer_sdp = 2;
map<string, TrackList> subscribed_participant_tracks = 3;
bool from_ingress = 4;
}

message WHIPCreateResponse {
Expand Down Expand Up @@ -101,4 +102,5 @@ message WHIPParticipantDeleteSessionRequest {
string room = 1;
string participant_identity = 2;
string participant_id = 3;
bool from_sweeper = 4;
}
140 changes: 100 additions & 40 deletions rpc/ingress.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading