TEL-459: route outbound sip traffic through a proxy - #643
Merged
Conversation
alexlivekit
approved these changes
Apr 1, 2026
hechen-eng
force-pushed
the
out_fe
branch
2 times, most recently
from
April 1, 2026 23:24
1b53df5 to
652db1a
Compare
dennwc
reviewed
Apr 3, 2026
| return AttrsToHeaders(r.LocalParticipant.Attributes(), c.sipConf.attrsToHeaders, headers) | ||
| }) | ||
| if sipConf.featureFlags[outboundRouteHeadersFeatureFlag] == "true" { | ||
| call.cc.routeHeaders = conf.OutboundRouteHeaders |
Contributor
There was a problem hiding this comment.
Maybe we should consider putting these URIs to the CreateSIPParticipant request instead? This would allow the user to add any external proxies to the path, as we as Cloud who will inject it's own set of URIs. In that case we won't need a feature flag here even.
Contributor
Author
There was a problem hiding this comment.
Good idea, and I think it'll be helpful to do percentage traffic migration there. That being said, feature flag is still useful here if we only want to enable it for UHG, which is our plan. We may need both..
hechen-eng
force-pushed
the
out_fe
branch
3 times, most recently
from
April 5, 2026 03:28
c62f82f to
9453e13
Compare
This reverts commit 864dff4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.