Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ai/live: Simplify payments API around readers #3447

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ai/live: Simplify payments API around readers #3447

wants to merge 1 commit into from

Conversation

j0sh
Copy link
Collaborator

@j0sh j0sh commented Mar 21, 2025

No description provided.

@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Mar 21, 2025
leszko
leszko requested changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly checked and I think this PR made the payment stopped from being sent for some reason.

When I have a moment, I'll take a closer look.

Base automatically changed from ja/payments-logging to master March 21, 2025 16:09
@j0sh j0sh mentioned this pull request Mar 25, 2025
Merged
@j0sh j0sh force-pushed the ja/payments-reader branch from 9a1f15b to e24711d Compare March 25, 2025 00:19
@j0sh
Copy link
Collaborator Author

j0sh commented Mar 25, 2025

Rebased and force pushed to resolve merge conflicts, no changes

@j0sh
Copy link
Collaborator Author

j0sh commented Mar 25, 2025

@leszko Was looking at some unrelated things and realized that #3468 might explain why payments seems to stop running sometimes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leszko leszko leszko requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
AI Issues and PR related to the AI-video branch. go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j0sh @leszko