Preserve the final state at the end of the e2e test in kind#390
Merged
waltforme merged 1 commit intollm-d-incubation:mainfrom Mar 27, 2026
Merged
Preserve the final state at the end of the e2e test in kind#390waltforme merged 1 commit intollm-d-incubation:mainfrom
waltforme merged 1 commit intollm-d-incubation:mainfrom
Conversation
Signed-off-by: Jun Duan <jun.duan.phd@outlook.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the launcher-based kind E2E script to keep the created Kubernetes resources around at the end of a successful run, making it easier to inspect the cluster state and debug the test behavior.
Changes:
- Replace end-of-test deletion of test resources (ReplicaSet and CRs) with scaling the requester ReplicaSet to zero.
- Keep the remaining test CRs in the cluster for post-run inspection while still verifying requester pods are gone.
| @@ -459,11 +459,7 @@ cheer Successful unbound launcher deletion cleanup | |||
|
|
|||
| : Clean up launcher-based workloads | |||
There was a problem hiding this comment.
The section header says “Clean up launcher-based workloads”, but the new behavior intentionally preserves most resources (only scaling the ReplicaSet down). Consider updating the header/comment to reflect that this is now a “scale down / preserve state for inspection” step so future readers don’t assume the test fully cleans up.
Suggested change
| : Clean up launcher-based workloads | |
| : Scale down launcher-based workloads (preserve resources for inspection) |
aavarghese
approved these changes
Mar 26, 2026
Collaborator
aavarghese
left a comment
aavarghese
left a comment
There was a problem hiding this comment.
LGTM for helping with bug investigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is helpful to examine the e2e test itself.