Skip to content

Preserve the final state at the end of the e2e test in kind #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waltforme merged 1 commit into from
Mar 27, 2026
Merged

Preserve the final state at the end of the e2e test in kind #390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions test/e2e/run-launcher-based.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,11 +459,7 @@ cheer Successful unbound launcher deletion cleanup

: Clean up launcher-based workloads
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section header says “Clean up launcher-based workloads”, but the new behavior intentionally preserves most resources (only scaling the ReplicaSet down). Consider updating the header/comment to reflect that this is now a “scale down / preserve state for inspection” step so future readers don’t assume the test fully cleans up.

Suggested change
: Clean up launcher-based workloads
: Scale down launcher-based workloads (preserve resources for inspection)

Copilot uses AI. Check for mistakes.

kubectl delete rs $rslb --ignore-not-found=true
kubectl delete launcherpopulationpolicy $lpp --ignore-not-found=true
kubectl delete inferenceserverconfig $isc --ignore-not-found=true
kubectl delete inferenceserverconfig $isc2 --ignore-not-found=true
kubectl delete launcherconfig $lc --ignore-not-found=true
expect '[ $(kubectl get pods -o name | grep -c "^pod/my-request-") == "0" ]'
kubectl scale rs $rslb --replicas=0
expect '[ $(kubectl get pods -o name | grep "^pod/my-request-" | wc -l) == "0" ]'

cheer All launcher-based tests passed
Loading