CI: Add link checker - fails PR if links are broken#118
Merged
jgchn merged 1 commit intollm-d-incubation:mainfrom Sep 18, 2025
Merged
CI: Add link checker - fails PR if links are broken#118jgchn merged 1 commit intollm-d-incubation:mainfrom
jgchn merged 1 commit intollm-d-incubation:mainfrom
Conversation
jgchn
reviewed
Sep 16, 2025
README.md
Outdated
| - P/D disaggregation | ||
| - Multi-node inference, utilizing data parallelism | ||
| - One pod per node (see [`llm-d-infra`](https://github.com/llm-d-incubation/llm-d-infra/tree/main/quickstart/examples/wide-ep-lws) for the ModelService [values](https://github.com/llm-d-incubation/llm-d-infra/tree/main/quickstart/examples/wide-ep-lws/ms-wide-ep/values.yaml) file) | ||
| - One pod per node (see [`llm-d-infra`](https://github.com/llm-d-incubation/llm-d-infra/tree/main/quickstart/examples/wide-ep-lws) for the ModelService [values](https://github.com/llm-d/llm-d/blob/dev/guides/wide-ep-lws/ms-wide-ep/values.yaml) file) |
Collaborator
There was a problem hiding this comment.
Wait the second link doesn't work for me, however the CI still passed?
Collaborator
Author
There was a problem hiding this comment.
HI @jgchn
The link was accessible during the CI run, but it became inaccessible again after the modification on the llm-d/llm-d#206 (2025-09-16).
I did an experiment, it can indeed report an error: https://github.com/llm-d-incubation/llm-d-modelservice/actions/runs/17783597346/job/50547059554?pr=118
yankay
force-pushed
the
add-lychee
branch
3 times, most recently
from
91a950f to
53999db
Compare
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
jgchn
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to recent issues with broken links (#115), the CI system will now include a link checker that causes pull requests to fail if any broken links are detected.
Reference: llm-d/llm-d-inference-scheduler#130