Skip to content

chore(release): prepare v0.8.0#348

Open
shimib wants to merge 3 commits into
llm-d:mainfrom
shimib:release/v0.8.0
Open

chore(release): prepare v0.8.0#348
shimib wants to merge 3 commits into
llm-d:mainfrom
shimib:release/v0.8.0

Conversation

@shimib

@shimib shimib commented Jul 24, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Prepares the v0.8.0 release and restores the release build flow that #328 broke.

Release prep

Release-build fix (targeted partial revert of #328)

  • Re-adds the three root replace directives.
  • Reverts the Dockerfile to COPY producer/ (drops the go work edit -dropuse ./producer step).

#328 swapped the root replaces for go.work, but go.work overrides module source, not the module-graph version requirement — and go mod tidy / docker build ignore it. So bumping to a not-yet-tagged version failed everywhere: PR container-build, the tag-time release image build, and make set-version. Restoring the replaces makes all siblings resolve locally without needing the tags. go.work is kept for dev; #328's lint fix and Makefile tweaks are retained. A full git revert of #328 was avoided because it would reintroduce the gochecknoglobals lint failure #328 fixed. See #328 for discussion.

Validated locally: workspace go build/go vet, GOWORK=off go build, go mod tidy (no-op), and a full docker build all pass.

Release steps after merge

git tag v0.8.0 && git push origin v0.8.0
# CI - Tag Go Submodules creates api/v0.8.0, pipeline/v0.8.0, producer/v0.8.0
# CI - Release builds ghcr.io/llm-d/llm-d-async:v0.8.0 + charts/llm-d-async:v0.8.0

Release note

NONE

Bump cross-module require versions to v0.8.0 and assemble the six
unreleased release-note fragments into RELEASE-NOTES.md.

Versions were edited manually (go mod edit) rather than via
`make set-version`, because llm-d#328 removed the root replace directives in
favor of go.work: `go mod tidy` ignores go.work, so it cannot resolve
the not-yet-tagged sibling versions. See llm-d#328 for the follow-up.

Signed-off-by: Shimi Bandiel <shimib@google.com>
shimib added 2 commits July 24, 2026 17:01
llm-d#328 replaced the root replace directives with go.work and made the
Dockerfile drop ./producer. But go.work overrides module *source*, not
the module-graph version requirement, and `go mod tidy`/`docker build`
ignore it — so any bump to a not-yet-tagged version (e.g. v0.8.0) fails
to build (PR container-build, release image build, and `make set-version`).

Restore the three root replace directives and revert the Dockerfile to
COPY producer/ so all siblings resolve locally without needing tags.
go.work is kept for IDE/dev; llm-d#328's lint fix and Makefile tweaks are
retained. See llm-d#328 for the broader discussion.

Signed-off-by: Shimi Bandiel <shimib@google.com>
The assemble-release-notes script left a trailing blank line that the
end-of-file-fixer pre-commit hook rejects.

Signed-off-by: Shimi Bandiel <shimib@google.com>

@zdtsw zdtsw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants