remove version.json references from Makefile#137
Merged
elevran merged 3 commits intollm-d:mainfrom Jun 4, 2025
Merged
Conversation
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
vMaroon
previously approved these changes
May 25, 2025
elevran
changed the title
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
vMaroon
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cleanup/maintenance PR. The
version.jsonfile was removed from the project (consolidated tomain, releases are triggered on git tags, etc.). Thus removing all references and targets in Makefile that make use of the version file.There are additional, lingering, settings for DEV_VERSION and PROD_VERSION in the Makefile (defaulting to 0.0.x).
Changing them requires some additional work and investigation (e.g., get default PROD_VERSION from GH tags and or releases, set DEV_VERSION based on current SHA, etc.) which are beyond the scope of this PR.
Fix #133