Replace ubi9 image for ubi-minimal to reduce footprint#153
Conversation
Signed-off-by: Ricardo Noriega De Soto <rnoriega@redhat.com>
Co-authored-by: Kfir Toledo <kfir.toledo@gmail.com> Signed-off-by: Etai Lev Ran <elevran@gmail.com>
Co-authored-by: Kfir Toledo <kfir.toledo@gmail.com> Signed-off-by: Etai Lev Ran <elevran@gmail.com>
|
This is a minor patch, but I think it's quite a bad practice in open source communities to work on top of other contributor's PR without any consultation. I don't mind about this particular one, but it is very discouraging. |
|
My apologies @oglok and thanks for the feedback. The intent was to push it forward so it can be merged (and the suggestions were, IMO, minor and required corrections in comments). |
|
The mode of operation should be discussed at the llm-d governance level, or per project, and it's whatever we agree. For merging PRs, it could be just one core reviewer approval, or two core reviewer approvals. In general, unless a group of people is working on a big feature which can be co-authors of the commits, a PR is pushed, reviewed, and the author/owner of the PR is the one to address those comments, or discuss them in case there is a reason behind the logic of the PR. |
|
@elevran – Just a quick note for future PRs: unless a change is truly time-critical and can't wait, it's generally best practice to let the original author address review comments. It gives them a chance to respond, learn from the feedback, and decide whether they agree with the suggested changes. It's also a more courteous approach that helps foster a positive and collaborative environment. Rewriting someone’s contribution without their involvement can discourage future contributions, which we definitely want to avoid. |
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com> Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
This could be a good start to reduce image size as reported in #152