Skip to content

Replace ubi9 image for ubi-minimal to reduce footprint#153

Merged
oglok merged 4 commits intollm-d:mainfrom
oglok:ubi-minimal
Jun 3, 2025
Merged

Replace ubi9 image for ubi-minimal to reduce footprint#153
oglok merged 4 commits intollm-d:mainfrom
oglok:ubi-minimal

Conversation

@oglok
Copy link
Contributor

@oglok oglok commented May 28, 2025

This could be a good start to reduce image size as reported in #152

Signed-off-by: Ricardo Noriega De Soto <rnoriega@redhat.com>
@kfirtoledo kfirtoledo linked an issue May 29, 2025 that may be closed by this pull request
kfirtoledo
kfirtoledo previously approved these changes May 29, 2025
Copy link
Collaborator

@kfirtoledo kfirtoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

Co-authored-by: Kfir Toledo <kfir.toledo@gmail.com>
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
Co-authored-by: Kfir Toledo <kfir.toledo@gmail.com>
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
@oglok
Copy link
Contributor Author

oglok commented May 30, 2025

This is a minor patch, but I think it's quite a bad practice in open source communities to work on top of other contributor's PR without any consultation. I don't mind about this particular one, but it is very discouraging.

@elevran
Copy link
Collaborator

elevran commented May 30, 2025

My apologies @oglok and thanks for the feedback. The intent was to push it forward so it can be merged (and the suggestions were, IMO, minor and required corrections in comments).
However, will refrain from it in the future.
Would you suggest that both suggestions and rebasing, in general, are left to the original author?

@oglok
Copy link
Contributor Author

oglok commented May 30, 2025

The mode of operation should be discussed at the llm-d governance level, or per project, and it's whatever we agree. For merging PRs, it could be just one core reviewer approval, or two core reviewer approvals. In general, unless a group of people is working on a big feature which can be co-authors of the commits, a PR is pushed, reviewed, and the author/owner of the PR is the one to address those comments, or discuss them in case there is a reason behind the logic of the PR.
Open source mode of operation might seem to slow things down, but it allows people to reach consensus and create better projects.

@anfredette
Copy link

@elevran – Just a quick note for future PRs: unless a change is truly time-critical and can't wait, it's generally best practice to let the original author address review comments. It gives them a chance to respond, learn from the feedback, and decide whether they agree with the suggested changes. It's also a more courteous approach that helps foster a positive and collaborative environment. Rewriting someone’s contribution without their involvement can discourage future contributions, which we definitely want to avoid.

@oglok oglok merged commit 0ac70df into llm-d:main Jun 3, 2025
2 checks passed
Jooho pushed a commit to Jooho/llm-d-inference-scheduler that referenced this pull request Sep 30, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce image size for inference scheduler

4 participants