[Build]: Update clean-env-dev-kind target in Makefile and fix vllm-sim image version #155
Merged
kfirtoledo merged 2 commits intollm-d:mainfrom Jun 3, 2025
Merged
[Build]: Update clean-env-dev-kind target in Makefile and fix vllm-sim image version #155kfirtoledo merged 2 commits intollm-d:mainfrom
kfirtoledo merged 2 commits intollm-d:mainfrom
Conversation
Collaborator
|
Please see #153
… @kfirtoledo <https://github.com/kfirtoledo> requested your review on: #155
<#155> [Build]
Change base image to ubi9-minimal.
|
Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
kfirtoledo
changed the title
Collaborator
Author
|
@elevran PTAL |
elevran
changed the title
elevran
previously approved these changes
May 30, 2025
Collaborator
elevran
left a comment
elevran
left a comment
There was a problem hiding this comment.
probably want to consider setting images based on latest available instead of hard coding defaults. There is an issue tracking that
shmuelk
requested changes
Jun 3, 2025
Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
Collaborator
Author
|
@shmuelk PTAL |
shmuelk
approved these changes
Jun 3, 2025
elevran
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes:
That makes the target
env-dev-kindrun properly.