fix: correct shell command substitution syntax in Makefile#276
Merged
nirrozenbaum merged 1 commit intollm-d:mainfrom Aug 8, 2025
Merged
fix: correct shell command substitution syntax in Makefile#276nirrozenbaum merged 1 commit intollm-d:mainfrom
nirrozenbaum merged 1 commit intollm-d:mainfrom
Conversation
elevran
approved these changes
Aug 5, 2025
Collaborator
|
@yankay would you kindly rebase on the latest so we can move ahead merging the PR? |
Contributor
Author
Collaborator
|
|
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
Contributor
Author
|
Thanks @elevran I've validate the rebase , it's ok :-) |
Collaborator
|
Thanks @yankay 🙏🏼 |
andresllh
pushed a commit
to andresllh/llm-d-inference-scheduler
that referenced
this pull request
Jan 14, 2026
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com> Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Makefile syntax issues by correcting shell command substitution and indentation errors.
Problem Solved
Resolves "Unsupported Linux package manager" error when running
make download-zmqon Ubuntu systems. logs:The issue was caused by incorrect Make variable substitution syntax, where $(command -v apt)was being evaluated by Make at parse time instead of being passed to the shell for runtime evaluation.
It also fixed an indentation error in
uninstall-docker.