Skip to content

fix: correct shell command substitution syntax in Makefile#276

Merged
nirrozenbaum merged 1 commit intollm-d:mainfrom
yankay:fix-makefile
Aug 8, 2025
Merged

fix: correct shell command substitution syntax in Makefile#276
nirrozenbaum merged 1 commit intollm-d:mainfrom
yankay:fix-makefile

Conversation

@yankay
Copy link
Contributor

@yankay yankay commented Aug 5, 2025

Summary

Fix Makefile syntax issues by correcting shell command substitution and indentation errors.

Problem Solved

Resolves "Unsupported Linux package manager" error when running make download-zmq on Ubuntu systems. logs:

# make download-zmq
Checking if ZMQ is already installed...
Installing ZMQ dependencies...
Unsupported Linux package manager. Install libzmq manually.
make: *** [Makefile:339: download-zmq] Error 1

The issue was caused by incorrect Make variable substitution syntax, where $(command -v apt)was being evaluated by Make at parse time instead of being passed to the shell for runtime evaluation.

It also fixed an indentation error in uninstall-docker.

@elevran
Copy link
Collaborator

elevran commented Aug 7, 2025

@yankay would you kindly rebase on the latest so we can move ahead merging the PR?

@yankay
Copy link
Contributor Author

yankay commented Aug 7, 2025

@yankay would you kindly rebase on the latest so we can move ahead merging the PR?

Thanks @elevran
It has been merged :-)

@elevran
Copy link
Collaborator

elevran commented Aug 7, 2025

main seems to be somewhat of a moving target.
Let me know if you're ok with me rebasing and merging or prefer to validate the rebase yourself.

Signed-off-by: Kay Yan <kay.yan@daocloud.io>
@yankay
Copy link
Contributor Author

yankay commented Aug 8, 2025

Thanks @elevran

I've validate the rebase , it's ok :-)

@nirrozenbaum
Copy link
Collaborator

Thanks @yankay 🙏🏼

@nirrozenbaum nirrozenbaum merged commit 54fa924 into llm-d:main Aug 8, 2025
3 checks passed
andresllh pushed a commit to andresllh/llm-d-inference-scheduler that referenced this pull request Jan 14, 2026
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants