Skip to content

fix: correct shell command substitution syntax in Makefile #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nirrozenbaum merged 1 commit into from
Aug 8, 2025
Merged

fix: correct shell command substitution syntax in Makefile #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ install-docker: check-container-tool ## Install app using $(CONTAINER_TOOL)
.PHONY: uninstall-docker
uninstall-docker: check-container-tool ## Uninstall app from $(CONTAINER_TOOL)
@echo "Stopping and removing container in $(CONTAINER_TOOL)..."
-$(CONTAINER_TOOL) stop $(PROJECT_NAME)-container && $(CONTAINER_TOOL) rm $(PROJECT_NAME)-container
@echo "$(CONTAINER_TOOL) uninstallation complete. Remove alias if set: unalias $(PROJECT_NAME)"
$(CONTAINER_TOOL) stop $(PROJECT_NAME)-container && $(CONTAINER_TOOL) rm $(PROJECT_NAME)-container
@echo "$(CONTAINER_TOOL) uninstallation complete. Remove alias if set: unalias $(PROJECT_NAME)"

### Kubernetes Targets (kubectl)

Expand Down Expand Up @@ -341,16 +341,16 @@ download-zmq: ## Install ZMQ dependencies based on OS/ARCH
else \
echo "Installing ZMQ dependencies..."; \
if [ "$(TARGETOS)" = "linux" ]; then \
if [ -x "$(command -v apt)" ]; then \
if [ -x "$$(command -v apt)" ]; then \
apt update && apt install -y libzmq3-dev; \
elif [ -x "$(command -v dnf)" ]; then \
elif [ -x "$$(command -v dnf)" ]; then \
dnf install -y zeromq-devel; \
else \
echo "Unsupported Linux package manager. Install libzmq manually."; \
exit 1; \
fi; \
elif [ "$(TARGETOS)" = "darwin" ]; then \
if [ -x "$(command -v brew)" ]; then \
if [ -x "$$(command -v brew)" ]; then \
brew install zeromq; \
else \
echo "Homebrew is not installed and is required to install zeromq. Install it from https://brew.sh/"; \
Expand Down
Loading