Merged
Conversation
shmuelk
requested changes
Aug 31, 2025
Makefile
Outdated
|
|
||
| .PHONY: test | ||
| test: test-unit test-e2e ## Run unit tests and e2e tests | ||
| test: test-unit test-e2e |
Collaborator
There was a problem hiding this comment.
Please add back the help text
Makefile
Outdated
|
|
||
| .PHONY: test-unit | ||
| test-unit: download-tokenizer download-zmq ## Run unit tests | ||
| test-unit: download-tokenizer install-dependencies |
Collaborator
There was a problem hiding this comment.
Please add back the help text
Makefile
Outdated
|
|
||
| .PHONY: test-integration | ||
| test-integration: download-tokenizer download-zmq ## Run integration tests | ||
| test-integration: download-tokenizer install-dependencies |
Collaborator
There was a problem hiding this comment.
Please add back the help text
Signed-off-by: Maroon Ayoub <maroon.ayoub@ibm.com>
shmuelk
approved these changes
Aug 31, 2025
Collaborator
|
/lgtm /approve |
github-actions
bot
added
the
lgtm
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg-configfor macOSRelated Issues
make test-unitfails with missing dependencies related build errors #286