sync gic to latest v1.0.0 release#353
Merged
github-actions[bot] merged 2 commits intollm-d:mainfrom Sep 16, 2025
Merged
Conversation
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
nirrozenbaum
commented
Sep 16, 2025
| if test.wantRes2 != nil { // Checking the prefix match in the decode pod. | ||
| // make sure prefix plugin stores the prefix hit in cache, so we can test it in the following schedule call | ||
| prefixScorer.PreRequest(ctx, test.req, got, 0) | ||
| time.Sleep(time.Second) |
Collaborator
Author
There was a problem hiding this comment.
this is a temp solution until it's solved appropriately in IGW.
PreRequest is adding the information to the cache asynchronously, so we need to wait.
this should be solved in next version and then we should remove this line from our tests.
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
Collaborator
|
/lgtm /approve |
github-actions
bot
added
the
lgtm
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nirrozenbaum
added a commit
that referenced
this pull request
Sep 17, 2025
* sync gic to latest v1.0.0 release Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * missed one more update Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.