Skip to content

sync gic to latest v1.0.0 release #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 2 commits into from
Sep 16, 2025
Merged

sync gic to latest v1.0.0 release #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e597b9
sync gic to latest v1.0.0 release
nirrozenbaum Sep 16, 2025
65e12be
missed one more update
nirrozenbaum Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy/components/crds-gie/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- https://github.com/kubernetes-sigs/gateway-api-inference-extension/config/crd?ref=v1.0.0-rc.3
- https://github.com/kubernetes-sigs/gateway-api-inference-extension/config/crd?ref=v1.0.0
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ require (
k8s.io/client-go v0.34.0
sigs.k8s.io/controller-runtime v0.22.0
sigs.k8s.io/gateway-api v1.3.0
sigs.k8s.io/gateway-api-inference-extension v1.0.0-rc.3
sigs.k8s.io/gateway-api-inference-extension v1.0.0
)

require (
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,8 +394,8 @@ sigs.k8s.io/controller-runtime v0.22.0 h1:mTOfibb8Hxwpx3xEkR56i7xSjB+nH4hZG37Srl
sigs.k8s.io/controller-runtime v0.22.0/go.mod h1:FwiwRjkRPbiN+zp2QRp7wlTCzbUXxZ/D4OzuQUDwBHY=
sigs.k8s.io/gateway-api v1.3.0 h1:q6okN+/UKDATola4JY7zXzx40WO4VISk7i9DIfOvr9M=
sigs.k8s.io/gateway-api v1.3.0/go.mod h1:d8NV8nJbaRbEKem+5IuxkL8gJGOZ+FJ+NvOIltV8gDk=
sigs.k8s.io/gateway-api-inference-extension v1.0.0-rc.3 h1:kdCGsKzxY4bu1JQ1t4FhPBke47OYJtP95Jn2bWHtIU0=
sigs.k8s.io/gateway-api-inference-extension v1.0.0-rc.3/go.mod h1:qxSY10qt2+YnZJ43VfpMXa6wpiENPderI2BnNZ4Kxfc=
sigs.k8s.io/gateway-api-inference-extension v1.0.0 h1:GsHvlu1Cn1t6+vrHoPdNNlpwKxf/y1HuQSlUjd58Ds8=
sigs.k8s.io/gateway-api-inference-extension v1.0.0/go.mod h1:qxSY10qt2+YnZJ43VfpMXa6wpiENPderI2BnNZ4Kxfc=
sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8 h1:gBQPwqORJ8d8/YNZWEjoZs7npUVDpVXUUOFfW6CgAqE=
sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8/go.mod h1:mdzfpAEoE6DHQEN0uh9ZbOCuHbLK5wOm7dK4ctXE9Tg=
sigs.k8s.io/randfill v1.0.0 h1:JfjMILfT8A6RbawdsK2JXGBR5AQVfd+9TbzrlneTyrU=
Expand Down
2 changes: 2 additions & 0 deletions pkg/scheduling/pd/scheduler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package pd_test
import (
"context"
"testing"
"time"

"github.com/go-logr/logr/testr"
"github.com/google/go-cmp/cmp"
Expand Down Expand Up @@ -238,6 +239,7 @@ func TestPDSchedule(t *testing.T) {
if test.wantRes2 != nil { // Checking the prefix match in the decode pod.
// make sure prefix plugin stores the prefix hit in cache, so we can test it in the following schedule call
prefixScorer.PreRequest(ctx, test.req, got, 0)
time.Sleep(time.Second)
Copy link
Collaborator Author

@nirrozenbaum nirrozenbaum Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a temp solution until it's solved appropriately in IGW.
PreRequest is adding the information to the cache asynchronously, so we need to wait.
this should be solved in next version and then we should remove this line from our tests.


got, err = scheduler.Schedule(ctx, test.req, test.input)
if test.err != (err != nil) {
Expand Down
Loading