Skip to content

Makefile refactoring to minimize the number of targets#397

Merged
shmuelk merged 3 commits intollm-d:mainfrom
shmuelk:makefile-updates
Nov 2, 2025
Merged

Makefile refactoring to minimize the number of targets#397
shmuelk merged 3 commits intollm-d:mainfrom
shmuelk:makefile-updates

Conversation

@shmuelk
Copy link
Collaborator

@shmuelk shmuelk commented Oct 29, 2025

The Makefile has been refactored to:
1. Reduce the number of targets in the file by the use of targets and actions that exploit the % wildcard
2. Improved consistency in naming of targets.

In addition the following targets have changed:

  • build now builds both of the EPP and the Sidecar simple binaries
  • image-build now builds both of the EPP and the Sidecar images
  • image-push now pushes both of the EPP and the Sidecar images
  • test-unit now runs the unit tests of both the EPP and the Sidecar

To run the above targets for just one of the EPP or the sidecar, run:

  • epp-buiild or sidecar-build
  • epp-image-build or sidecar-image-build
  • epp-image-push or sidecar-image-push
  • epp-test-unit or sidecar-test-unit

Fixes: #385

@elevran
Copy link
Collaborator

elevran commented Oct 30, 2025

/lgtm

@github-actions github-actions bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2025
@elevran
Copy link
Collaborator

elevran commented Oct 31, 2025

@shmuelk please resolve conflict

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
@elevran
Copy link
Collaborator

elevran commented Nov 2, 2025

/approve

@shmuelk shmuelk merged commit 221e500 into llm-d:main Nov 2, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in llm-d-inference-scheduler Nov 2, 2025
@shmuelk shmuelk deleted the makefile-updates branch November 2, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Improve the UX of the Makefile

2 participants