Makefile refactoring to minimize the number of targets#397
Merged
shmuelk merged 3 commits intollm-d:mainfrom Nov 2, 2025
Merged
Makefile refactoring to minimize the number of targets#397shmuelk merged 3 commits intollm-d:mainfrom
shmuelk merged 3 commits intollm-d:mainfrom
Conversation
This was referenced Oct 29, 2025
cfe753f to
233eb9f
Compare
Collaborator
|
/lgtm |
Collaborator
|
@shmuelk please resolve conflict |
233eb9f to
5191d01
Compare
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
5191d01 to
034f5b2
Compare
Collaborator
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Makefile has been refactored to:
1. Reduce the number of targets in the file by the use of targets and actions that exploit the % wildcard
2. Improved consistency in naming of targets.
In addition the following targets have changed:
buildnow builds both of the EPP and the Sidecar simple binariesimage-buildnow builds both of the EPP and the Sidecar imagesimage-pushnow pushes both of the EPP and the Sidecar imagestest-unitnow runs the unit tests of both the EPP and the SidecarTo run the above targets for just one of the EPP or the sidecar, run:
epp-buiildorsidecar-buildepp-image-buildorsidecar-image-buildepp-image-pushorsidecar-image-pushepp-test-unitorsidecar-test-unitFixes: #385